Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4387)

Unified Diff: chrome/installer/util/shell_util_unittest.cc

Issue 1926403002: Remove BrowserDistribution::SHORTCUT_APP_LAUNCHER (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20160406-Mac-EnableAppLauncher0
Patch Set: lint headers Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/shell_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/shell_util_unittest.cc
diff --git a/chrome/installer/util/shell_util_unittest.cc b/chrome/installer/util/shell_util_unittest.cc
index b46b755a3e214a233b13d4d868b15396977061a9..cd625dd08992f16daaf699d6b9b5781a63bedf38 100644
--- a/chrome/installer/util/shell_util_unittest.cc
+++ b/chrome/installer/util/shell_util_unittest.cc
@@ -135,9 +135,9 @@ class ShellUtilShortcutTest : public testing::Test {
return base::FilePath();
}
- base::string16 shortcut_name = properties.has_shortcut_name() ?
- properties.shortcut_name :
- dist_->GetShortcutName(BrowserDistribution::SHORTCUT_CHROME);
+ base::string16 shortcut_name = properties.has_shortcut_name()
+ ? properties.shortcut_name
+ : dist_->GetShortcutName();
shortcut_name.append(installer::kLnkExt);
return expected_path.Append(shortcut_name);
}
@@ -175,7 +175,7 @@ class ShellUtilShortcutTest : public testing::Test {
if (properties.has_icon()) {
expected_properties.set_icon(properties.icon, properties.icon_index);
} else {
- int icon_index = dist->GetIconIndex(BrowserDistribution::SHORTCUT_CHROME);
+ int icon_index = dist->GetIconIndex();
expected_properties.set_icon(chrome_exe_, icon_index);
}
@@ -358,9 +358,7 @@ TEST_F(ShellUtilShortcutTest, CreateIfNoSystemLevel) {
}
TEST_F(ShellUtilShortcutTest, CreateIfNoSystemLevelWithSystemLevelPresent) {
- base::string16 shortcut_name(
- dist_->GetShortcutName(BrowserDistribution::SHORTCUT_CHROME) +
- installer::kLnkExt);
+ base::string16 shortcut_name(dist_->GetShortcutName() + installer::kLnkExt);
test_properties_.level = ShellUtil::SYSTEM_LEVEL;
ASSERT_TRUE(ShellUtil::CreateOrUpdateShortcut(
@@ -388,9 +386,7 @@ TEST_F(ShellUtilShortcutTest, CreateIfNoSystemLevelStartMenu) {
}
TEST_F(ShellUtilShortcutTest, CreateAlwaysUserWithSystemLevelPresent) {
- base::string16 shortcut_name(
- dist_->GetShortcutName(BrowserDistribution::SHORTCUT_CHROME) +
- installer::kLnkExt);
+ base::string16 shortcut_name(dist_->GetShortcutName() + installer::kLnkExt);
test_properties_.level = ShellUtil::SYSTEM_LEVEL;
ASSERT_TRUE(ShellUtil::CreateOrUpdateShortcut(
@@ -777,9 +773,7 @@ TEST_F(ShellUtilShortcutTest,
dist_, test_properties_,
ShellUtil::SHELL_SHORTCUT_CREATE_ALWAYS));
- base::string16 shortcut_name(
- dist_->GetShortcutName(BrowserDistribution::SHORTCUT_CHROME) +
- installer::kLnkExt);
+ base::string16 shortcut_name(dist_->GetShortcutName() + installer::kLnkExt);
base::FilePath shortcut_path(
fake_start_menu_.path().Append(shortcut_name));
@@ -806,9 +800,7 @@ TEST_F(ShellUtilShortcutTest, DontRemoveChromeShortcutIfPointsToAnotherChrome) {
ShellUtil::SHORTCUT_LOCATION_DESKTOP, dist_, test_properties_,
ShellUtil::SHELL_SHORTCUT_CREATE_ALWAYS));
- base::string16 shortcut_name(
- dist_->GetShortcutName(BrowserDistribution::SHORTCUT_CHROME) +
- installer::kLnkExt);
+ base::string16 shortcut_name(dist_->GetShortcutName() + installer::kLnkExt);
base::FilePath shortcut_path(fake_user_desktop_.path().Append(shortcut_name));
ASSERT_TRUE(base::PathExists(shortcut_path));
« no previous file with comments | « chrome/installer/util/shell_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698