chrome/installer/util/prebuild/create_string_rc.py - Issue 1926403002: Remove BrowserDistribution::SHORTCUT_APP_LAUNCHER

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/prebuild/create_string_rc.py

Issue 1926403002: Remove BrowserDistribution::SHORTCUT_APP_LAUNCHER (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20160406-Mac-EnableAppLauncher0

Patch Set: Update comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/app_list/win/app_list_service_win.cc ('K') | « chrome/installer/util/google_chrome_sxs_distribution.cc ('k') | chrome/installer/util/shell_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/prebuild/create_string_rc.py

diff --git a/chrome/installer/util/prebuild/create_string_rc.py b/chrome/installer/util/prebuild/create_string_rc.py

index 2ff941a01b46f388253ed7b58f5f4414f6a77956..f12790796779bc694cbb02e343c59d735afc5c7c 100755

--- a/chrome/installer/util/prebuild/create_string_rc.py

+++ b/chrome/installer/util/prebuild/create_string_rc.py

@@ -65,8 +65,6 @@ STRING_IDS = [

'IDS_INSTALL_MULTI_INSTALLATION_EXISTS',

'IDS_SHORTCUT_TOOLTIP',

'IDS_SHORTCUT_NEW_WINDOW',

huangs 2016/05/04 15:54:08 Code search shows that these strings appear in mor

tapted 2016/05/05 07:14:18 This will come in a follow-up, but these need to g

- 'IDS_APP_LIST_SHORTCUT_NAME',

- 'IDS_APP_LIST_SHORTCUT_NAME_CANARY',

'IDS_APP_SHORTCUTS_SUBDIR_NAME',

'IDS_APP_SHORTCUTS_SUBDIR_NAME_CANARY',

'IDS_INBOUND_MDNS_RULE_NAME',