Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 1926403002: Remove BrowserDistribution::SHORTCUT_APP_LAUNCHER (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20160406-Mac-EnableAppLauncher0
Patch Set: lint headers Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file defines specific implementation of BrowserDistribution class for 5 // This file defines specific implementation of BrowserDistribution class for
6 // Google Chrome. 6 // Google Chrome.
7 7
8 #include "chrome/installer/util/google_chrome_distribution.h" 8 #include "chrome/installer/util/google_chrome_distribution.h"
9 9
10 #include <windows.h> 10 #include <windows.h>
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 return GetAppGuid(); 151 return GetAppGuid();
152 } 152 }
153 153
154 base::string16 GoogleChromeDistribution::GetBaseAppName() { 154 base::string16 GoogleChromeDistribution::GetBaseAppName() {
155 // I'd really like to return L ## PRODUCT_FULLNAME_STRING; but that's no good 155 // I'd really like to return L ## PRODUCT_FULLNAME_STRING; but that's no good
156 // since it'd be "Chromium" in a non-Chrome build, which isn't at all what I 156 // since it'd be "Chromium" in a non-Chrome build, which isn't at all what I
157 // want. Sigh. 157 // want. Sigh.
158 return L"Google Chrome"; 158 return L"Google Chrome";
159 } 159 }
160 160
161 base::string16 GoogleChromeDistribution::GetShortcutName( 161 base::string16 GoogleChromeDistribution::GetShortcutName() {
162 ShortcutType shortcut_type) { 162 return installer::GetLocalizedString(IDS_PRODUCT_NAME_BASE);
163 int string_id = IDS_PRODUCT_NAME_BASE;
164 switch (shortcut_type) {
165 case SHORTCUT_APP_LAUNCHER:
166 string_id = IDS_APP_LIST_SHORTCUT_NAME_BASE;
167 break;
168 default:
169 DCHECK_EQ(SHORTCUT_CHROME, shortcut_type);
170 break;
171 }
172 return installer::GetLocalizedString(string_id);
173 } 163 }
174 164
175 int GoogleChromeDistribution::GetIconIndex(ShortcutType shortcut_type) { 165 int GoogleChromeDistribution::GetIconIndex() {
176 if (shortcut_type == SHORTCUT_APP_LAUNCHER)
177 return icon_resources::kAppLauncherIndex;
178 DCHECK_EQ(SHORTCUT_CHROME, shortcut_type);
179 return icon_resources::kApplicationIndex; 166 return icon_resources::kApplicationIndex;
180 } 167 }
181 168
182 base::string16 GoogleChromeDistribution::GetBaseAppId() { 169 base::string16 GoogleChromeDistribution::GetBaseAppId() {
183 return kBrowserAppId; 170 return kBrowserAppId;
184 } 171 }
185 172
186 base::string16 GoogleChromeDistribution::GetBrowserProgIdPrefix() { 173 base::string16 GoogleChromeDistribution::GetBrowserProgIdPrefix() {
187 return kBrowserProgIdPrefix; 174 return kBrowserProgIdPrefix;
188 } 175 }
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 GetAppGuid()); 277 GetAppGuid());
291 } 278 }
292 279
293 bool GoogleChromeDistribution::ShouldSetExperimentLabels() { 280 bool GoogleChromeDistribution::ShouldSetExperimentLabels() {
294 return true; 281 return true;
295 } 282 }
296 283
297 bool GoogleChromeDistribution::HasUserExperiments() { 284 bool GoogleChromeDistribution::HasUserExperiments() {
298 return true; 285 return true;
299 } 286 }
OLDNEW
« no previous file with comments | « chrome/installer/util/google_chrome_distribution.h ('k') | chrome/installer/util/google_chrome_distribution_dummy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698