Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1560)

Side by Side Diff: src/compiler/x87/instruction-selector-x87.cc

Issue 1926383002: X87: [turbofan] Enable concurrent (re)compilation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 #include "src/compiler/node-properties.h" 8 #include "src/compiler/node-properties.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 57
58 bool CanBeImmediate(Node* node) { 58 bool CanBeImmediate(Node* node) {
59 switch (node->opcode()) { 59 switch (node->opcode()) {
60 case IrOpcode::kInt32Constant: 60 case IrOpcode::kInt32Constant:
61 case IrOpcode::kNumberConstant: 61 case IrOpcode::kNumberConstant:
62 case IrOpcode::kExternalConstant: 62 case IrOpcode::kExternalConstant:
63 case IrOpcode::kRelocatableInt32Constant: 63 case IrOpcode::kRelocatableInt32Constant:
64 case IrOpcode::kRelocatableInt64Constant: 64 case IrOpcode::kRelocatableInt64Constant:
65 return true; 65 return true;
66 case IrOpcode::kHeapConstant: { 66 case IrOpcode::kHeapConstant: {
67 // TODO(bmeurer): We must not dereference handles concurrently. If we
68 // really have to this here, then we need to find a way to put this
69 // information on the HeapConstant node already.
70 #if 0
67 // Constants in new space cannot be used as immediates in V8 because 71 // Constants in new space cannot be used as immediates in V8 because
68 // the GC does not scan code objects when collecting the new generation. 72 // the GC does not scan code objects when collecting the new generation.
69 Handle<HeapObject> value = OpParameter<Handle<HeapObject>>(node); 73 Handle<HeapObject> value = OpParameter<Handle<HeapObject>>(node);
70 Isolate* isolate = value->GetIsolate(); 74 Isolate* isolate = value->GetIsolate();
71 return !isolate->heap()->InNewSpace(*value); 75 return !isolate->heap()->InNewSpace(*value);
76 #endif
72 } 77 }
73 default: 78 default:
74 return false; 79 return false;
75 } 80 }
76 } 81 }
77 82
78 AddressingMode GenerateMemoryOperandInputs(Node* index, int scale, Node* base, 83 AddressingMode GenerateMemoryOperandInputs(Node* index, int scale, Node* base,
79 Node* displacement_node, 84 Node* displacement_node,
80 InstructionOperand inputs[], 85 InstructionOperand inputs[],
81 size_t* input_count) { 86 size_t* input_count) {
(...skipping 1531 matching lines...) Expand 10 before | Expand all | Expand 10 after
1613 MachineOperatorBuilder::kFloat32RoundTruncate | 1618 MachineOperatorBuilder::kFloat32RoundTruncate |
1614 MachineOperatorBuilder::kFloat64RoundTruncate | 1619 MachineOperatorBuilder::kFloat64RoundTruncate |
1615 MachineOperatorBuilder::kFloat32RoundTiesEven | 1620 MachineOperatorBuilder::kFloat32RoundTiesEven |
1616 MachineOperatorBuilder::kFloat64RoundTiesEven; 1621 MachineOperatorBuilder::kFloat64RoundTiesEven;
1617 return flags; 1622 return flags;
1618 } 1623 }
1619 1624
1620 } // namespace compiler 1625 } // namespace compiler
1621 } // namespace internal 1626 } // namespace internal
1622 } // namespace v8 1627 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698