Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 1926353002: Revert of [Extensions] More bindings improvements (Closed)

Created:
2 years, 10 months ago by Devlin
Modified:
2 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Revert of [Extensions] More bindings improvements (patchset #1 id:1 of https://codereview.chromium.org/1930213002/ ) Reason for revert: Compile fail Original issue's description: > [Extensions] More bindings improvements > > Explicitly freeze the schema in chrome, pass safe arguments to GetAvailability, > and broaden test access checks. > > BUG=604901 > BUG=603725 > BUG=591164 > > Review URL: https://codereview.chromium.org/1899973002 > > Cr-Commit-Position: refs/heads/master@{#388353} > (cherry picked from commit 585b125ef7168c104631e23ee5cad0108c838f52) > > Committed: https://chromium.googlesource.com/chromium/src/+/f0f07d08bc3865436994b40aa620d8063fe7bbcc TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=604901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M extensions/renderer/module_system_test.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/renderer/resources/binding.js View 3 chunks +4 lines, -7 lines 0 comments Download
M extensions/renderer/script_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/v8_schema_registry.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Devlin
Created Revert of [Extensions] More bindings improvements
2 years, 10 months ago (2016-04-29 00:32:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926353002/1
2 years, 10 months ago (2016-04-29 00:33:08 UTC) #2
commit-bot: I haz the power
2 years, 10 months ago (2016-04-29 00:34:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698