Issue 192633002: Move ContentAutofillDriver to the PasswordManager component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 192633002: Move ContentAutofillDriver to the PasswordManager component. (Closed)

Created:
6 years, 9 months ago by blundell

Modified:
6 years, 9 months ago

Reviewers:
Patrick Dubroy, darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move ContentAutofillDriver to the PasswordManager component. As ContentAutofillDriver is the //content-based driver implementation for the PasswordManager component, it belongs within the component itself rather than in the //chrome embedder of the component. BUG=348515 R=dubroy@chromium.org TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255932

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -171 lines)			Patch
M	chrome/browser/password_manager/chrome_password_manager_client.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/password_manager/content_password_manager_driver.h	View	1 chunk	+0 lines, -57 lines	0 comments	Download
D	chrome/browser/password_manager/content_password_manager_driver.cc	View	1 chunk	+0 lines, -107 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	components/password_manager.gypi	View	1 chunk	+28 lines, -0 lines	0 comments	Download
A +	components/password_manager/content/DEPS	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	components/password_manager/content/browser/DEPS	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A +	components/password_manager/content/browser/content_password_manager_driver.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	components/password_manager/content/browser/content_password_manager_driver.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blundell

TBR=darin for the creation of the DEPS files (and the dependencies that they add) under ...

6 years, 9 months ago (2014-03-10 12:54:06 UTC) #3

blundell

6 years, 9 months ago (2014-03-10 12:59:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r255932 (presubmit successful).

Expand Messages | Collapse Messages