Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceLoader.h

Issue 1926193002: Clean up ResourceLoader finish more, remove ConnectionState enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@finish_smaller
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceLoader.h
diff --git a/third_party/WebKit/Source/core/fetch/ResourceLoader.h b/third_party/WebKit/Source/core/fetch/ResourceLoader.h
index c618bc9a410285c204ffba8e26a82808928679d6..0dccf6f23a91a66833b789e4998488c0322a392a 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceLoader.h
+++ b/third_party/WebKit/Source/core/fetch/ResourceLoader.h
@@ -48,13 +48,8 @@ public:
~ResourceLoader() override;
DECLARE_TRACE();
- // Promptly release m_loader.
- EAGERLY_FINALIZE();
-
void start(ResourceRequest&);
-
void cancel();
- void cancel(const ResourceError&);
Resource* cachedResource() { return m_resource.get(); }
@@ -73,7 +68,7 @@ public:
void didFail(WebURLLoader*, const WebURLError&) override;
void didDownloadData(WebURLLoader*, int, int) override;
- void didFinishLoadingOnePart(double finishTime, int64_t encodedDataLength);
+ void didFinishLoadingFirstPartInMultipart();
private:
// Assumes ResourceFetcher and Resource are non-null.
@@ -83,29 +78,9 @@ private:
bool responseNeedsAccessControlCheck() const;
- ResourceRequest& applyOptions(ResourceRequest&) const;
-
- void releaseResources();
-
OwnPtr<WebURLLoader> m_loader;
Member<ResourceFetcher> m_fetcher;
-
- bool m_notifiedLoadComplete;
-
- enum ConnectionState {
- ConnectionStateNew,
- ConnectionStateStarted,
- ConnectionStateReceivedResponse,
- ConnectionStateReceivingData,
- ConnectionStateFinishedLoading,
- ConnectionStateReleased
- };
-
Member<Resource> m_resource;
-
- // Used for sanity checking to make sure we don't experience illegal state
- // transitions.
- ConnectionState m_state;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698