Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.h

Issue 1926193002: Clean up ResourceLoader finish more, remove ConnectionState enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@finish_smaller
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.h
diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.h b/third_party/WebKit/Source/core/fetch/ResourceFetcher.h
index 627f1fe8c165d6698718a1636a616595f88328bb..a92b66fc772b19e1484a8ef6baea245691717fbf 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.h
+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.h
@@ -103,19 +103,15 @@ public:
void stopFetching();
bool isFetching() const;
- void didLoadResource(Resource*);
bool willFollowRedirect(Resource*, ResourceRequest&, const ResourceResponse&);
- void didFinishLoading(Resource*, double finishTime, int64_t encodedDataLength);
- void didFailLoading(const Resource*, const ResourceError&);
+ void didFinishLoading(Resource*, double finishTime, int64_t encodedDataLength, bool isFirstPartInMultipart);
yhirano 2016/05/13 10:33:03 It would be good to replace this boolean with enum
Nate Chapin 2016/05/13 22:27:41 Done.
+ void didFailLoading(Resource*, const ResourceError&);
void didReceiveResponse(const Resource*, const ResourceResponse&);
void didReceiveData(const Resource*, const char* data, int dataLength, int encodedDataLength);
void didDownloadData(const Resource*, int dataLength, int encodedDataLength);
void willStartLoadingResource(Resource*, ResourceLoader*, ResourceRequest&);
bool defersLoading() const;
- void moveResourceLoaderToNonBlocking(ResourceLoader*);
- void removeResourceLoader(ResourceLoader*);
-
enum AccessControlLoggingDecision {
ShouldLogAccessControlErrors,
ShouldNotLogAccessControlErrors
@@ -164,6 +160,8 @@ private:
RevalidationPolicy determineRevalidationPolicy(Resource::Type, const FetchRequest&, Resource* existingResource, bool isStaticData) const;
void moveCachedNonBlockingResourceToBlocking(Resource*, const FetchRequest&);
+ void moveResourceLoaderToNonBlocking(ResourceLoader*);
+ void removeResourceLoader(ResourceLoader*);
void initializeResourceRequest(ResourceRequest&, Resource::Type, FetchRequest::DeferOption);

Powered by Google App Engine
This is Rietveld 408576698