Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1926143002: [polymer] Makes ContainerThatDecoratesItsChildren use HTMLDivElement (Closed)

Created:
4 years, 7 months ago by charliea (OOO until 10-5)
Modified:
4 years, 7 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@polymer10-migration
Target Ref:
refs/heads/polymer10-migration
Project:
catapult
Visibility:
Public.

Description

[polymer] Makes ContainerThatDecoratesItsChildren use HTMLDivElement NOTRY=true NOPRESUBMIT=true BUG=catapult:#2285 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c118e6857a3aba3e84a7d10130f67dc5b50c69e7

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M tracing/tracing/ui/base/container_that_decorates_its_children.html View 3 chunks +6 lines, -7 lines 2 comments Download

Messages

Total messages: 9 (5 generated)
charliea (OOO until 10-5)
https://codereview.chromium.org/1926143002/diff/40001/tracing/tracing/ui/base/container_that_decorates_its_children.html File tracing/tracing/ui/base/container_that_decorates_its_children.html (left): https://codereview.chromium.org/1926143002/diff/40001/tracing/tracing/ui/base/container_that_decorates_its_children.html#oldcode39 tracing/tracing/ui/base/container_that_decorates_its_children.html:39: Polymer.dom(HTMLUnknownElement.prototype).appendChild.call(this, x); I don't think that we need to ...
4 years, 7 months ago (2016-04-28 18:02:15 UTC) #4
aiolos (Not reviewing)
lgtm https://codereview.chromium.org/1926143002/diff/40001/tracing/tracing/ui/base/container_that_decorates_its_children.html File tracing/tracing/ui/base/container_that_decorates_its_children.html (left): https://codereview.chromium.org/1926143002/diff/40001/tracing/tracing/ui/base/container_that_decorates_its_children.html#oldcode39 tracing/tracing/ui/base/container_that_decorates_its_children.html:39: Polymer.dom(HTMLUnknownElement.prototype).appendChild.call(this, x); On 2016/04/28 18:02:15, charliea (slow) wrote: ...
4 years, 7 months ago (2016-04-28 18:03:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926143002/40001
4 years, 7 months ago (2016-04-28 18:04:08 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 18:04:17 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698