Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1926133003: Several tiny cleanups in test-parsing.cc (Closed)

Created:
4 years, 7 months ago by adamk
Modified:
4 years, 7 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Several tiny cleanups in test-parsing.cc R=littledan@chromium.org Committed: https://crrev.com/f1a0f054fb57f1fb1ac0b0ed05e909549d72a5cb Cr-Commit-Position: refs/heads/master@{#35890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M test/cctest/test-parsing.cc View 8 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
4 years, 7 months ago (2016-04-29 00:40:53 UTC) #1
Dan Ehrenberg
lgtm
4 years, 7 months ago (2016-04-29 00:56:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926133003/1
4 years, 7 months ago (2016-04-29 00:59:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 06:44:11 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:18 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f1a0f054fb57f1fb1ac0b0ed05e909549d72a5cb
Cr-Commit-Position: refs/heads/master@{#35890}

Powered by Google App Engine
This is Rietveld 408576698