Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 192613002: [Telemetry] rename _needs_browser_restart_after_each_run -> <...>_each_page (Closed)

Created:
6 years, 9 months ago by jeremy
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] rename _needs_browser_restart_after_each_run -> <...>_each_page Rename to reflect what this actually does. BUG=350832 TBR=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M content/test/gpu/gpu_tests/context_lost.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/gpu_process.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/startup.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_measurement.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jeremy
6 years, 9 months ago (2014-03-10 10:14:21 UTC) #1
marja
rubberstamp lgtm (only variable renaming)
6 years, 9 months ago (2014-03-10 10:24:40 UTC) #2
jeremy
The CQ bit was checked by jeremy@chromium.org
6 years, 9 months ago (2014-03-10 11:25:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/192613002/1
6 years, 9 months ago (2014-03-10 11:25:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/192613002/1
6 years, 9 months ago (2014-03-10 13:00:38 UTC) #5
commit-bot: I haz the power
Change committed as 255937
6 years, 9 months ago (2014-03-10 13:26:43 UTC) #6
Ken Russell (switch to Gerrit)
6 years, 9 months ago (2014-03-10 21:20:35 UTC) #7
Message was sent while issue was closed. 
LGTM FWIW

Powered by Google App Engine
This is Rietveld 408576698