Issue 1926103002: [Polymer10] Upgrade base_chart.html to extend HTMLDivElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1926103002: [Polymer10] Upgrade base_chart.html to extend HTMLDivElement (Closed)

Created:
4 years, 7 months ago by eakuefner

Modified:
4 years, 7 months ago

Reviewers:
aiolos (Not reviewing)

CC:
catapult-reviews_chromium.org, tracing-review_chromium.org

Base URL:
git@github.com:catapult-project/catapult.git@polymer10-migration

Target Ref:
refs/heads/polymer10-migration

Project:
catapult

Visibility:
Public.

[Polymer10] Upgrade base_chart.html to extend HTMLDivElement HTMLUnknownElement is a really crazy thing to extend, so this changes base_chart to extend HTMLDivElement and fixes 34 unit tests in the process. BUG=catapult:#2285 R=aiolos@chromium.org Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6096b9935b794eb6867e56ccdc329aad1c6ae5e4

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tracing/tracing/ui/base/chart_base.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

eakuefner

4 years, 7 months ago (2016-04-28 16:47:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6096b9935b794eb6867e56ccdc329aad1c6ae5e4 (presubmit successful).