Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1926063002: Adjust tolerance to fix bezier glitches issue (Closed)

Created:
4 years, 7 months ago by xidachen
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Adjust tolerance to fix bezier glitches issue In a previous CL: https://codereview.chromium.org/1126793003, the value of gDegenerateToLineTol was changed from 1.0 to 0.25 which caused the bezier glitches. This CL changes the value to SK_ScalarRoot2Over2, with this change the bezier curve looks fine, and the result of the layout tests pointed out in this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=472847 is also reasonable. BUG=605439 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926063002 Committed: https://skia.googlesource.com/skia/+/45a6f49ef9ff276e08025d0d2ba6a821a96d3f34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
xidachen
PTAL
4 years, 7 months ago (2016-04-28 14:40:05 UTC) #3
jvanverth1
lgtm
4 years, 7 months ago (2016-04-28 20:02:40 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926063002/1
4 years, 7 months ago (2016-04-29 01:12:45 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-29 01:23:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926063002/1
4 years, 7 months ago (2016-04-29 01:24:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/45a6f49ef9ff276e08025d0d2ba6a821a96d3f34
4 years, 7 months ago (2016-04-29 01:25:32 UTC) #12
jvanverth1
4 years, 7 months ago (2016-04-29 14:38:03 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1933733002/ by jvanverth@google.com.

The reason for reverting is: This is causing undesirable image failures in a
large number of Skia GMs..

Powered by Google App Engine
This is Rietveld 408576698