Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Unified Diff: Source/core/rendering/FixedTableLayout.cpp

Issue 192603003: ASSERTION FAILED: type() == Percent in WebCore::Length::percent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@extractedstyle
Patch Set: Support for fixed table layouts, test update and comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/FixedTableLayout.cpp
diff --git a/Source/core/rendering/FixedTableLayout.cpp b/Source/core/rendering/FixedTableLayout.cpp
index 25e4b83ffd3f5746cc2a6f0b066df58cfbec8e4a..d0474cb35ece085744f80ebe89274f3e3eb5f1f6 100644
--- a/Source/core/rendering/FixedTableLayout.cpp
+++ b/Source/core/rendering/FixedTableLayout.cpp
@@ -140,6 +140,11 @@ int FixedTableLayout::calcWidthArray()
RenderTableRow* firstRow = section->firstRow();
for (RenderTableCell* cell = firstRow->firstCell(); cell; cell = cell->nextCell()) {
Length logicalWidth = cell->styleOrColLogicalWidth();
+
+ // FIXME: calc() on tables should be handled consistently with other lengths. See bug: https://crbug.com/382725
+ if (logicalWidth.isCalculated())
+ logicalWidth = Length(); // Make it Auto
+
unsigned span = cell->colSpan();
int fixedBorderBoxLogicalWidth = 0;
// FIXME: Support other length types. If the width is non-auto, it should probably just use
« Source/core/rendering/AutoTableLayout.cpp ('K') | « Source/core/rendering/AutoTableLayout.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698