LayoutTests/fast/css/handling-calc-on-table-as-auto.html - Issue 192603003: ASSERTION FAILED: type() == Percent in WebCore::Length::percent

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/handling-calc-on-table-as-auto.html

Issue 192603003: ASSERTION FAILED: type() == Percent in WebCore::Length::percent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@extractedstyle

Patch Set: Fix typo in the expected. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../resources/check-layout.js"></script>

	5 <script>

	6 function test()

	7 {

	8 checkLayout('td');
	Julien - ping for review 2014/06/24 18:57:34 AFAICT you can just say checkLayout("td, table") AFAICT you can just say checkLayout("td, table")
	9 checkLayout('table');

	10 }

	11 </script>

	12 </head>

	13 <body onload="test()">

	14 <p>Test for handling calc() values on table elements as if they were Auto. Check crbug.com/350852 for details.</p>

	15 <table cellpadding="0" cellspacing="0" data-expected-width="132" data-expexted-h eight="100">
	Julien - ping for review 2014/06/24 18:57:34 width = 132px is wrong. If you follow the CSS comp width = 132px is wrong. If you follow the CSS computation, it should be 100px (width of the td + 0px padding + 0px border). The issue is that checkLayout inserts a child inside the table, which ends up adding a new cell and modifying the width. The fix is to add: <div id="output"></div> outside the <table> and call checkLayout("td, table", output) (or if you prefer checkLayout("td, table", document.getElementById("output"))). Also typo data-expexted-height
	16 <tr>

	17 <td colspan="5" style="width: calc(100% + 100px);" data-expected-width=" 100" data-expected-height="100">

	18 <div style="height: 100px; width: 100px"/>

	19 </td>

	20 </tr>

	21 </table>

	22

	23 <table cellpadding="0" cellspacing="0" style="table-layout:fixed;" data-expected -width="132" data-expexted-height="100">

	24 <tr>

	25 <td colspan="5" style="width: calc(100% + 100px);" data-expected-width=" 100" data-expected-height="100">

	26 <div style="height: 100px; width: 100px"/>

	27 </td>

	28 </tr>

	29 </table>

	30 </body>

	31 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css/handling-calc-on-table-as-auto-expected.txt » ('j') | no next file with comments »