Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1926023003: Revert of MacViews: add extension install dialog to MacViewsWebUIDialogs (Closed)

Created:
4 years, 7 months ago by Elly Fong-Jones
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MacViews: add extension install dialog to MacViewsWebUIDialogs (patchset #2 id:20001 of https://codereview.chromium.org/1918793004/ ) Reason for revert: Breaks mac_views_browser=1 build. Original issue's description: > MacViews: add extension install dialog to MacViewsWebUIDialogs > > This dialog is now behind the MacViewsWebUIDialogs feature flag. > > BUG=605657 > > Committed: https://crrev.com/145ffb972813fef174d6a96f2ca97983ede90c8a > Cr-Commit-Position: refs/heads/master@{#389779} TBR=sky@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=605657 Committed: https://crrev.com/b39009a349414ee6c0ac184d8125ce82aee3ac24 Cr-Commit-Position: refs/heads/master@{#390397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -29 lines) Patch
M chrome/browser/extensions/extension_install_prompt.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Elly Fong-Jones
Created Revert of MacViews: add extension install dialog to MacViewsWebUIDialogs
4 years, 7 months ago (2016-04-28 15:12:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926023003/1
4 years, 7 months ago (2016-04-28 15:13:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926023003/1
4 years, 7 months ago (2016-04-28 15:31:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 15:56:37 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:18:59 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b39009a349414ee6c0ac184d8125ce82aee3ac24
Cr-Commit-Position: refs/heads/master@{#390397}

Powered by Google App Engine
This is Rietveld 408576698