Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1926003003: blink_gc_plugin: drop no-op options. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink_gc_plugin: drop no-op options. With the updated GC clang plugin that rolled out as part of issue 604993, we can now assume that the enable-oilpan and warn-raw-ptr options are by default always on & consequently doesn't need to be passed in by blink_gc_plugin_flags.py R= BUG=604463, 604476 Committed: https://crrev.com/01d8280352825197825e139a60f38ab0cf11b9b8 Cr-Commit-Position: refs/heads/master@{#390631}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M tools/clang/scripts/blink_gc_plugin_flags.py View 1 chunk +1 line, -13 lines 1 comment Download

Messages

Total messages: 12 (3 generated)
sof
please take a look. if accepted, will wait a day or two just in case ...
4 years, 7 months ago (2016-04-28 14:16:35 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-04-28 14:17:13 UTC) #3
Nico
do you want to change gn files too (e.g. https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/BUILD.gn&l=84 ?)
4 years, 7 months ago (2016-04-28 14:43:47 UTC) #4
sof
On 2016/04/28 14:43:47, Nico wrote: > do you want to change gn files too (e.g. ...
4 years, 7 months ago (2016-04-28 14:51:13 UTC) #5
Nico
lgtm
4 years, 7 months ago (2016-04-28 15:04:32 UTC) #6
sof
https://codereview.chromium.org/1926003003/diff/1/tools/clang/scripts/blink_gc_plugin_flags.py File tools/clang/scripts/blink_gc_plugin_flags.py (left): https://codereview.chromium.org/1926003003/diff/1/tools/clang/scripts/blink_gc_plugin_flags.py#oldcode31 tools/clang/scripts/blink_gc_plugin_flags.py:31: elif arg == 'warn-unneeded-finalizer=1': After the next roll, it ...
4 years, 7 months ago (2016-04-29 07:19:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926003003/1
4 years, 7 months ago (2016-04-29 12:00:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 12:44:43 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:25:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01d8280352825197825e139a60f38ab0cf11b9b8
Cr-Commit-Position: refs/heads/master@{#390631}

Powered by Google App Engine
This is Rietveld 408576698