Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6254)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1926003002: Add metrics for coalesced permission prompts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index 8d38d0451210d25d95cecac7af49fd236e0d2b1b..07d34c34db251448968f81055f5980459b7ec82d 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -286,4 +286,19 @@ void PermissionUmaUtil::PermissionPromptShown(
"Permissions.Prompt.Shown",
static_cast<base::HistogramBase::Sample>(permission_prompt_type),
static_cast<base::HistogramBase::Sample>(PermissionBubbleType::NUM));
+
+ UMA_HISTOGRAM_ENUMERATION(
+ "Permissions.Prompt.RequestsPerPrompt",
+ static_cast<base::HistogramBase::Sample>(requests.size()),
+ static_cast<base::HistogramBase::Sample>(10));
+
+ if (requests.size() > 1) {
+ for (const auto* request : requests) {
+ UMA_HISTOGRAM_ENUMERATION(
+ "Permissions.Prompt.MergedBubbleTypes",
+ static_cast<base::HistogramBase::Sample>(
+ request->GetPermissionBubbleType()),
felt 2016/04/28 23:55:19 i am wondering, how do you plan to interpret this?
benwells 2016/04/29 00:07:51 That's right. We'd know that camera, mic and geo o
felt 2016/04/29 00:19:43 if you are looking for specific combinations (like
+ static_cast<base::HistogramBase::Sample>(PermissionBubbleType::NUM));
+ }
+ }
}
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698