Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 1926003002: Add metrics for coalesced permission prompts. (Closed)

Created:
4 years, 7 months ago by benwells
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add metrics for coalesced permission prompts. The metrics track how many requests each prompt contains, and which types of permission requests are getting merged. BUG=603384 Committed: https://crrev.com/893ab263c7a8bfe016013e773d32271b444c47f3 Cr-Commit-Position: refs/heads/master@{#391606}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M chrome/browser/permissions/permission_uma_util.cc View 1 chunk +15 lines, -0 lines 3 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +15 lines, -4 lines 1 comment Download

Messages

Total messages: 13 (3 generated)
benwells
https://codereview.chromium.org/1926003002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1926003002/diff/1/tools/metrics/histograms/histograms.xml#oldcode35880 tools/metrics/histograms/histograms.xml:35880: -<histogram name="Permissions.Prompt.Shown" enum="PermissionBubbleType"> I mistakenly left in this histogram ...
4 years, 7 months ago (2016-04-28 12:55:24 UTC) #2
felt
quick q https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/permission_uma_util.cc File chrome/browser/permissions/permission_uma_util.cc (right): https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/permission_uma_util.cc#newcode300 chrome/browser/permissions/permission_uma_util.cc:300: request->GetPermissionBubbleType()), i am wondering, how do you ...
4 years, 7 months ago (2016-04-28 23:55:19 UTC) #3
benwells
https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/permission_uma_util.cc File chrome/browser/permissions/permission_uma_util.cc (right): https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/permission_uma_util.cc#newcode300 chrome/browser/permissions/permission_uma_util.cc:300: request->GetPermissionBubbleType()), On 2016/04/28 23:55:19, felt wrote: > i am ...
4 years, 7 months ago (2016-04-29 00:07:51 UTC) #4
felt
lgtm % food for thought https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/permission_uma_util.cc File chrome/browser/permissions/permission_uma_util.cc (right): https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/permission_uma_util.cc#newcode300 chrome/browser/permissions/permission_uma_util.cc:300: request->GetPermissionBubbleType()), On 2016/04/29 00:07:51, ...
4 years, 7 months ago (2016-04-29 00:19:44 UTC) #5
benwells
On 2016/04/29 00:19:44, felt wrote: > lgtm % food for thought > > https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/permission_uma_util.cc > ...
4 years, 7 months ago (2016-04-29 00:41:27 UTC) #6
benwells
asvitkine: friendly ping...
4 years, 7 months ago (2016-05-04 16:58:00 UTC) #7
Alexei Svitkine (slow)
lgtm
4 years, 7 months ago (2016-05-04 17:02:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1926003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1926003002/1
4 years, 7 months ago (2016-05-04 18:31:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 20:01:28 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 20:03:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/893ab263c7a8bfe016013e773d32271b444c47f3
Cr-Commit-Position: refs/heads/master@{#391606}

Powered by Google App Engine
This is Rietveld 408576698