Add metrics for coalesced permission prompts.

Add metrics for coalesced permission prompts.

The metrics track how many requests each prompt contains, and which
types of permission requests are getting merged.

BUG=603384
Committed: https://crrev.com/893ab263c7a8bfe016013e773d32271b444c47f3
Cr-Commit-Position: refs/heads/master@{#391606}

[benwells, 2016-04-28 12:55:23]

benwells@chromium.org changed reviewers:
+ asvitkine@chromium.org, felt@chromium.org

[benwells, 2016-04-28 12:55:24]

https://codereview.chromium.org/1926003002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1926003002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:35880: -<histogram
name="Permissions.Prompt.Shown" enum="PermissionBubbleType">
I mistakenly left in this histogram description in a previous patch.

[felt, 2016-04-28 23:55:19]

quick q

https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_uma_util.cc (right):

https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_uma_util.cc:300:
request->GetPermissionBubbleType()),
i am wondering, how do you plan to interpret this? if we end up with a histogram
full of camera, mic, and geolocation, we still won't know which of them are
being requested together right?

[benwells, 2016-04-29 00:07:51]

https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_uma_util.cc (right):

https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_uma_util.cc:300:
request->GetPermissionBubbleType()),
On 2016/04/28 23:55:19, felt wrote:
> i am wondering, how do you plan to interpret this? if we end up with a
histogram
> full of camera, mic, and geolocation, we still won't know which of them are
> being requested together right?

That's right. We'd know that camera, mic and geo often get merged into other
things, but not what they get merged into.

We could explode out the combinations we report into one histogram enum:
mic+camera
mic+geo
camera+geo
mic+camera+geo

But I thought that seemed pretty complicated and I'm not sure its worth it.

[felt, 2016-04-29 00:19:44]

lgtm % food for thought

https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_uma_util.cc (right):

https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_uma_util.cc:300:
request->GetPermissionBubbleType()),
On 2016/04/29 00:07:51, benwells wrote:
> On 2016/04/28 23:55:19, felt wrote:
> > i am wondering, how do you plan to interpret this? if we end up with a
> histogram
> > full of camera, mic, and geolocation, we still won't know which of them are
> > being requested together right?
> 
> That's right. We'd know that camera, mic and geo often get merged into other
> things, but not what they get merged into.
> 
> We could explode out the combinations we report into one histogram enum:
> mic+camera
> mic+geo
> camera+geo
> mic+camera+geo
> 
> But I thought that seemed pretty complicated and I'm not sure its worth it.

if you are looking for specific combinations (like mic+camera) you could
specifically histogram those instead of everything. (actually my honest guess is
this will all be mic+camera anyway.)

[benwells, 2016-04-29 00:41:27]

On 2016/04/29 00:19:44, felt wrote:
> lgtm % food for thought
> 
>
https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/...
> File chrome/browser/permissions/permission_uma_util.cc (right):
> 
>
https://codereview.chromium.org/1926003002/diff/1/chrome/browser/permissions/...
> chrome/browser/permissions/permission_uma_util.cc:300:
> request->GetPermissionBubbleType()),
> On 2016/04/29 00:07:51, benwells wrote:
> > On 2016/04/28 23:55:19, felt wrote:
> > > i am wondering, how do you plan to interpret this? if we end up with a
> > histogram
> > > full of camera, mic, and geolocation, we still won't know which of them
are
> > > being requested together right?
> > 
> > That's right. We'd know that camera, mic and geo often get merged into other
> > things, but not what they get merged into.
> > 
> > We could explode out the combinations we report into one histogram enum:
> > mic+camera
> > mic+geo
> > camera+geo
> > mic+camera+geo
> > 
> > But I thought that seemed pretty complicated and I'm not sure its worth it.
> 
> if you are looking for specific combinations (like mic+camera) you could
> specifically histogram those instead of everything. (actually my honest guess
is
> this will all be mic+camera anyway.)

Interesting idea. Right now I'm just trying to get data, but adding specific
histograms (or specific histogram values in other metrics maybe) later sounds
like a good idea.

At the moment I don't think any of these will be mic+camera, not until Tim
finishes the job of refactoring the media stream stuff anyway.

[benwells, 2016-05-04 16:58:00]

asvitkine: friendly ping...

[Alexei Svitkine (slow), 2016-05-04 17:02:17]

lgtm

[benwells, 2016-05-04 18:30:59]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2016-05-04 18:31:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1926003002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1926003002/1

[commit-bot: I haz the power, 2016-05-04 20:01:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-04 20:03:11]

Description was changed from

==========
Add metrics for coalesced permission prompts.

The metrics track how many requests each prompt contains, and which
types of permission requests are getting merged.

BUG=603384
==========

to

==========
Add metrics for coalesced permission prompts.

The metrics track how many requests each prompt contains, and which
types of permission requests are getting merged.

BUG=603384

Committed: https://crrev.com/893ab263c7a8bfe016013e773d32271b444c47f3
Cr-Commit-Position: refs/heads/master@{#391606}
==========

[commit-bot: I haz the power, 2016-05-04 20:03:12]

Patchset 1 (id:??) landed as
https://crrev.com/893ab263c7a8bfe016013e773d32271b444c47f3
Cr-Commit-Position: refs/heads/master@{#391606}