Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1925993005: Simplify length-range-check in Array.prototype.push (Closed)

Created:
4 years, 7 months ago by Toon Verwaest
Modified:
4 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify length-range-check in Array.prototype.push BUG= Committed: https://crrev.com/efffb98b092e240489e9a4b07f42f666649c6d4f Cr-Commit-Position: refs/heads/master@{#35893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M src/js/array.js View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925993005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925993005/1
4 years, 7 months ago (2016-04-29 07:40:47 UTC) #2
Toon Verwaest
ptal
4 years, 7 months ago (2016-04-29 07:43:00 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-29 08:17:16 UTC) #6
Jakob Kummerow
lgtm
4 years, 7 months ago (2016-04-29 08:19:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925993005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925993005/1
4 years, 7 months ago (2016-04-29 08:53:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 09:00:36 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:22 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/efffb98b092e240489e9a4b07f42f666649c6d4f
Cr-Commit-Position: refs/heads/master@{#35893}

Powered by Google App Engine
This is Rietveld 408576698