Initial addition of Blimp engine crash client code (take 2)

chrome/common/crash_keys.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/crash_keys.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/format_macros.h"
 #include "base/logging.h"
@@ skipping 70 matching lines @@
 const char kKaskoEquivalentGuid[] = "kasko-equivalent-guid";
 #endif
 
 const char kViewCount[] = "view-count";
 
 const char kZeroEncodeDetails[] = "zero-encode-details";
 
 size_t RegisterChromeCrashKeys() {
   // The following keys may be chunked by the underlying crash logging system,
   // but ultimately constitute a single key-value pair.
+  //
+  // If you're adding keys here, please also add them to the list in

[Kevin M, 2016/05/02 22:05:32]

Maintaining two parallel key lists seems risky, and burdensome for contributors.

I recommend factoring out fixed_keys into a global array (kChromeCrashKeys?)
that we can reference and build off of in Blimp.

[Robert Sesek, 2016/05/02 22:07:00]

The CL description mentions a bug to fix this issue.

[marcinjb, 2016/05/03 18:06:58]

Yeah, I've got something going in http://crrev.com/1849413003, but that's going
to take some time finish and to land.  This CL is a way to get us crash
reporting sooner rather than later.

In parallel, the testing team is getting a buildbot to hopefully test some basic
interactions, so if someone introduces a breaking change, it'll get caught in
the CQ.

+  // //blimp/engine/app/blimp_engine_crash_keys.cc
   base::debug::CrashKey fixed_keys[] = {
 #if defined(OS_MACOSX) || defined(OS_WIN)
     { kMetricsClientId, kSmallSize },
 #else
     { kClientId, kSmallSize },
 #endif
     { kChannel, kSmallSize },
     { kActiveURL, kLargeSize },
     { kNumVariations, kSmallSize },
     { kVariations, kLargeSize },
@@ skipping 219 matching lines @@
 }
 
 ScopedPrinterInfo::~ScopedPrinterInfo() {
   for (size_t i = 0; i < kPrinterInfoCount; ++i) {
     std::string key = base::StringPrintf(kPrinterInfo, i + 1);
     base::debug::ClearCrashKey(key);
   }
 }
 
 }  // namespace crash_keys