Initial addition of Blimp engine crash client code (take 2)

blimp/engine/app/blimp_engine_crash_keys.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "blimp/engine/app/blimp_engine_crash_keys.h"
+
+#include <vector>
+
+#include "base/debug/crash_logging.h"
+#include "components/crash/core/common/crash_keys.h"
+
+namespace blimp {
+namespace engine {
+
+size_t RegisterEngineCrashKeys() {
+  // For now these need to be kept relatively up to date with those in
+  // //chrome/common/crash_keys.cc::RegisterChromeCrashKeys()
+  // All of the keys used in //content and //components/crash must show up
+  // here.
+  // TODO(marcinjb): Change the approach when http://crbug.com/598854 is
+  // resolved.
+  const std::vector<base::debug::CrashKey> engine_keys = {
+      { ::crash_keys::kClientId, ::crash_keys::kSmallSize },

[Robert Sesek, 2016/04/28 21:37:30]

Do you need to prefix everything with :: ?

[marcinjb, 2016/04/28 22:00:34]

Hmm, I think I originally had an additional nested crash_keys namespace here,
but that disappeared somewhere along the way (if that were the case, I'd
strongly have preferred the leading ::'s to remove any ambiguity).

Removed.

[Robert Sesek, 2016/04/28 22:02:50]

Right, and the compiler probably would want them to remove ambiguity too.

+      { ::crash_keys::kChannel, ::crash_keys::kSmallSize },
+      { ::crash_keys::kNumVariations, ::crash_keys::kSmallSize },
+      { ::crash_keys::kVariations, ::crash_keys::kLargeSize },
+
+      // //content crash keys
+      { "discardable-memory-allocated", ::crash_keys::kSmallSize },
+      { "discardable-memory-free", ::crash_keys::kSmallSize },
+      { "ppapi_path", ::crash_keys::kMediumSize },
+      { "subresource_url", ::crash_keys::kLargeSize },
+      { "total-discardable-memory-allocated", ::crash_keys::kSmallSize },
+      { "channel_error_bt", ::crash_keys::kMediumSize },
+      { "remove_route_bt", ::crash_keys::kMediumSize },
+      { "rwhvm_window", ::crash_keys::kMediumSize },
+
+      // Temporary for http://crbug.com/575245.
+      { "swapout_frame_id", ::crash_keys::kSmallSize },
+      { "swapout_proxy_id", ::crash_keys::kSmallSize },
+      { "swapout_view_id", ::crash_keys::kSmallSize },
+      { "commit_frame_id", ::crash_keys::kSmallSize },
+      { "commit_proxy_id", ::crash_keys::kSmallSize },
+      { "commit_view_id", ::crash_keys::kSmallSize },
+      { "commit_main_render_frame_id", ::crash_keys::kSmallSize },
+      { "newproxy_proxy_id", ::crash_keys::kSmallSize },
+      { "newproxy_view_id", ::crash_keys::kSmallSize },
+      { "newproxy_opener_id", ::crash_keys::kSmallSize },
+      { "newproxy_parent_id", ::crash_keys::kSmallSize },
+      { "rvinit_view_id", ::crash_keys::kSmallSize },
+      { "rvinit_proxy_id", ::crash_keys::kSmallSize },
+      { "rvinit_main_frame_id", ::crash_keys::kSmallSize },
+      { "initrf_frame_id", ::crash_keys::kSmallSize },
+      { "initrf_proxy_id", ::crash_keys::kSmallSize },
+      { "initrf_view_id", ::crash_keys::kSmallSize },
+      { "initrf_main_frame_id", ::crash_keys::kSmallSize },
+      { "initrf_view_is_live", ::crash_keys::kSmallSize },
+
+      // Temporary for https://crbug.com/591478.
+      { "initrf_parent_proxy_exists", ::crash_keys::kSmallSize },
+      { "initrf_render_view_is_live", ::crash_keys::kSmallSize },
+      { "initrf_parent_is_in_same_site_instance", ::crash_keys::kSmallSize},
+      { "initrf_parent_process_is_live", ::crash_keys::kSmallSize},
+      { "initrf_root_is_in_same_site_instance", ::crash_keys::kSmallSize},
+      { "initrf_root_is_in_same_site_instance_as_parent",
+        ::crash_keys::kSmallSize},
+      { "initrf_root_process_is_live", ::crash_keys::kSmallSize},
+      { "initrf_root_proxy_is_live", ::crash_keys::kSmallSize},
+    };
+
+  return base::debug::InitCrashKeys(&engine_keys.at(0), engine_keys.size(),
+                                    ::crash_keys::kChunkMaxLength);
+}
+
+}  // namespace engine
+}  // namespace blimp