Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1925983002:
Makes the IME APIs available for beta/stable channels. (Closed)
|
Created:
4 years, 7 months ago by Shu Chen Modified:
4 years, 3 months ago Reviewers:
Devlin CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMakes the IME APIs available for beta/stable channels.
BUG=607425, 517773
Committed: https://crrev.com/3f9aaee9da59138d3bde342bff4d18011694ef5f
Cr-Commit-Position: refs/heads/master@{#414313}
Patch Set 1 #Patch Set 2 : Makes the IME APIs available for beta/stable channels. #Patch Set 3 : . #
Total comments: 2
Patch Set 4 : .. #Messages
Total messages: 34 (13 generated)
shuchen@chromium.org changed reviewers: + rdevlin.cronin@chromium.org
Devlin, can you please review this? Thanks.
Devlin, can you please review this? Thanks.
On 2016/04/28 07:30:10, Shu Chen wrote: > Devlin, can you please review this? Thanks. Did this ever go through launch/ui review?
On 2016/04/28 15:53:24, Devlin wrote: > On 2016/04/28 07:30:10, Shu Chen wrote: > > Devlin, can you please review this? Thanks. > > Did this ever go through launch/ui review? crbug.com/517773 is in the process of reviews. Can you please suggest a UI reviewer for that?
On 2016/04/28 16:17:11, Shu Chen wrote: > On 2016/04/28 15:53:24, Devlin wrote: > > On 2016/04/28 07:30:10, Shu Chen wrote: > > > Devlin, can you please review this? Thanks. > > > > Did this ever go through launch/ui review? > > crbug.com/517773 is in the process of reviews. Can you please suggest a UI > reviewer for that? chrome-ui-review@google.com
On 2016/04/28 16:25:26, Devlin (ooo - July 6) wrote: > On 2016/04/28 16:17:11, Shu Chen wrote: > > On 2016/04/28 15:53:24, Devlin wrote: > > > On 2016/04/28 07:30:10, Shu Chen wrote: > > > > Devlin, can you please review this? Thanks. > > > > > > Did this ever go through launch/ui review? > > > > crbug.com/517773 is in the process of reviews. Can you please suggest a UI > > reviewer for that? > > mailto:chrome-ui-review@google.com Hi. I was wondering if there is going to be any progress on this CL? Maybe for M-54?
On 2016/07/04 19:58:58, EhsanK wrote: > On 2016/04/28 16:25:26, Devlin (ooo - July 6) wrote: > > On 2016/04/28 16:17:11, Shu Chen wrote: > > > On 2016/04/28 15:53:24, Devlin wrote: > > > > On 2016/04/28 07:30:10, Shu Chen wrote: > > > > > Devlin, can you please review this? Thanks. > > > > > > > > Did this ever go through launch/ui review? > > > > > > crbug.com/517773 is in the process of reviews. Can you please suggest a UI > > > reviewer for that? > > > > mailto:chrome-ui-review@google.com > > Hi. I was wondering if there is going to be any progress on this CL? Maybe for > M-54? The API is still targeting to launch in M53. Please refer to the launch bug crbug.com/517773. The pending bits are: Security, UI & Test. For Security and UI, they are almost settled down. For test, I've pinged in the launch bug but no echo back. Also, the LR meeting was schedule at 4:00am CST on 6/30, and I've asked to handle the LR over emails (while I don't know how to). Our PM (xiangye@ is in maternity leave) and I am kind of lost on how to push this forward. Can you please help? Thanks!
Hi Devlin, can you please approve this cl? The launch has been approved: crbug.com/517773.
lgtm
The CQ bit was checked by shuchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by shuchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rdevlin.cronin@chromium.org Link to the patchset: https://codereview.chromium.org/1925983002/#ps20001 (title: "Makes the IME APIs available for beta/stable channels.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by shuchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rdevlin.cronin@chromium.org Link to the patchset: https://codereview.chromium.org/1925983002/#ps40001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/1925983002/diff/40001/chrome/common/extension... File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/1925983002/diff/40001/chrome/common/extension... chrome/common/extensions/api/_permission_features.json:459: "inplies_full_url_access": true, Why are you adding this line?
https://codereview.chromium.org/1925983002/diff/40001/chrome/common/extension... File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/1925983002/diff/40001/chrome/common/extension... chrome/common/extensions/api/_permission_features.json:459: "inplies_full_url_access": true, On 2016/08/25 02:00:00, Devlin wrote: > Why are you adding this line? This was carried from the old patchset. I've now removed it.
The CQ bit was checked by shuchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rdevlin.cronin@chromium.org Link to the patchset: https://codereview.chromium.org/1925983002/#ps60001 (title: "..")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shuchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Makes the IME APIs available for beta/stable channels. BUG=607425,517773 ========== to ========== Makes the IME APIs available for beta/stable channels. BUG=607425,517773 Committed: https://crrev.com/3f9aaee9da59138d3bde342bff4d18011694ef5f Cr-Commit-Position: refs/heads/master@{#414313} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/3f9aaee9da59138d3bde342bff4d18011694ef5f Cr-Commit-Position: refs/heads/master@{#414313} |
