Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 1925973002: Remove unused GCObject class. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused GCObject class. This dummy class was accidentally re-introduced in PersistentNode.cpp during the r389469 revert; remove it. R= BUG= Committed: https://crrev.com/ca90ea2310c17735b8df076606cb845c3b0dc8f6 Cr-Commit-Position: refs/heads/master@{#390323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/heap/PersistentNode.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 7 months ago (2016-04-28 06:35:26 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-04-28 06:36:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925973002/1
4 years, 7 months ago (2016-04-28 06:37:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 07:50:00 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:16:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca90ea2310c17735b8df076606cb845c3b0dc8f6
Cr-Commit-Position: refs/heads/master@{#390323}

Powered by Google App Engine
This is Rietveld 408576698