Ignore HID elements in extraneous application collections on OSX

Ignore HID elements in extraneous application collections on OSX

Even though we only ask HID manager for devices that have relevant usage
numbers, matching devices may have elements that aren't in the collections
that we care about. These irrelevant elements take up valuable slots in
the WebGamepad object and crowd out the elements that we actually want.

The Nvidia Shield controller falls victim to these extra elements, which
prevent most of the gamepad controls from being usable at all.

BUG=607401
TEST=HTML5 Gamepad API test with Nvidia Shield controller

Committed: https://crrev.com/d908daba0f7dc5ae548a6c7e4719ec004f4bf10e
Cr-Commit-Position: refs/heads/master@{#390420}

[cgutman, 2016-04-28 05:21:58]

Description was changed from

==========
Ignore HID elements in extraneous application collections on OSX

Even though we only ask HID manager for devices that have relevant usage
numbers, matching devices may have elements that aren't in the collections
that we care about. These irrelevant elements take up valuable slots in
the WebGamepad object and crowd out the elements that we actually want.

The Nvidia Shield controller falls victim to these extra elements, which
prevent most of the gamepad controls from being usable at all.

BUG=607401
TEST=HTML5 Gamepad API test with Nvidia Shield controller
==========

to

==========
Ignore HID elements in extraneous application collections on OSX

Even though we only ask HID manager for devices that have relevant usage
numbers, matching devices may have elements that aren't in the collections
that we care about. These irrelevant elements take up valuable slots in
the WebGamepad object and crowd out the elements that we actually want.

The Nvidia Shield controller falls victim to these extra elements, which
prevent most of the gamepad controls from being usable at all.

BUG=607401
TEST=HTML5 Gamepad API test with Nvidia Shield controller
==========

[cgutman, 2016-04-28 05:21:58]

aicommander@gmail.com changed reviewers:
+ bajones@chromium.org, scottmg@chromium.org

[cgutman, 2016-04-28 05:25:29]

I found these extra HID collections were a problem when testing my Shield
controller on OS X in Chrome. Apologies if this CL seems out of left field to
you guys.

I've also filed a bug if you'd prefer we do the discussion there.
https://bugs.chromium.org/p/chromium/issues/detail?id=607401

[bajones, 2016-04-28 17:05:37]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2016-04-28 17:06:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925953002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925953002/1

[commit-bot: I haz the power, 2016-04-28 17:06:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 17:06:09]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bajones, 2016-04-28 17:07:26]

LGTM! Thanks for the contribution.

I've seen this problem before but wasn't familiar enough with OSX's HID
libraries to go after it. This code is clean and easy to follow, so I'm happy to
accept the patch.

[bajones, 2016-04-28 17:07:31]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2016-04-28 17:07:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925953002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925953002/1

[commit-bot: I haz the power, 2016-04-28 17:52:56]

Description was changed from

==========
Ignore HID elements in extraneous application collections on OSX

Even though we only ask HID manager for devices that have relevant usage
numbers, matching devices may have elements that aren't in the collections
that we care about. These irrelevant elements take up valuable slots in
the WebGamepad object and crowd out the elements that we actually want.

The Nvidia Shield controller falls victim to these extra elements, which
prevent most of the gamepad controls from being usable at all.

BUG=607401
TEST=HTML5 Gamepad API test with Nvidia Shield controller
==========

to

==========
Ignore HID elements in extraneous application collections on OSX

Even though we only ask HID manager for devices that have relevant usage
numbers, matching devices may have elements that aren't in the collections
that we care about. These irrelevant elements take up valuable slots in
the WebGamepad object and crowd out the elements that we actually want.

The Nvidia Shield controller falls victim to these extra elements, which
prevent most of the gamepad controls from being usable at all.

BUG=607401
TEST=HTML5 Gamepad API test with Nvidia Shield controller
==========

[commit-bot: I haz the power, 2016-04-28 17:52:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-30 17:19:33]

Patchset 1 (id:??) landed as
https://crrev.com/d908daba0f7dc5ae548a6c7e4719ec004f4bf10e
Cr-Commit-Position: refs/heads/master@{#390420}

[commit-bot: I haz the power, 2016-04-30 17:56:29]

Description was changed from

==========
Ignore HID elements in extraneous application collections on OSX

Even though we only ask HID manager for devices that have relevant usage
numbers, matching devices may have elements that aren't in the collections
that we care about. These irrelevant elements take up valuable slots in
the WebGamepad object and crowd out the elements that we actually want.

The Nvidia Shield controller falls victim to these extra elements, which
prevent most of the gamepad controls from being usable at all.

BUG=607401
TEST=HTML5 Gamepad API test with Nvidia Shield controller
==========

to

==========
Ignore HID elements in extraneous application collections on OSX

Even though we only ask HID manager for devices that have relevant usage
numbers, matching devices may have elements that aren't in the collections
that we care about. These irrelevant elements take up valuable slots in
the WebGamepad object and crowd out the elements that we actually want.

The Nvidia Shield controller falls victim to these extra elements, which
prevent most of the gamepad controls from being usable at all.

BUG=607401
TEST=HTML5 Gamepad API test with Nvidia Shield controller

Committed: https://crrev.com/d908daba0f7dc5ae548a6c7e4719ec004f4bf10e
Cr-Commit-Position: refs/heads/master@{#390420}
==========