Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1925833003: [Polymer10] Change HTMLTestRunner to extend HTMLDivElement (Closed)

Created:
4 years, 7 months ago by eakuefner
Modified:
4 years, 7 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@polymer10-migration
Target Ref:
refs/heads/polymer10-migration
Project:
catapult
Visibility:
Public.

Description

[Polymer10] Change HTMLTestRunner to extend HTMLDivElement HTMLTestRunner extends HTMLUnknownElement, which we think is dangerous. Extending HTMLDivElement instead doesn't make any more tests pass, but that's probably just because it isn't unit tested. It doesn't cause anything to break. BUG=catapult:#2285 NOPRESUBMIT=true NOTRY=true Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6c2c678e53c51758586bf071587008231fc9b7c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tracing/tracing/base/unittest/html_test_results.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
eakuefner
PTAL.
4 years, 7 months ago (2016-04-28 16:55:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925833003/1
4 years, 7 months ago (2016-04-28 16:55:43 UTC) #5
charliea (OOO until 10-5)
lgtm
4 years, 7 months ago (2016-04-28 16:55:44 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-04-28 16:55:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925833003/1
4 years, 7 months ago (2016-04-28 16:56:43 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 16:56:52 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698