Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 192583005: QUIC - rename |read_start_time_| to |disk_cache_load_start_time_|. (Closed)

Created:
6 years, 9 months ago by ramant (doing other things)
Modified:
6 years, 9 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

QUIC - rename |read_start_time_| to |disk_cache_load_start_time_|. R=wtc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256262

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reverted the histogram name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M net/quic/quic_crypto_client_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
ramant (doing other things)
6 years, 9 months ago (2014-03-10 20:41:36 UTC) #1
wtc
Patch set 1 LGTM. 1. We may not want to change the histogram's name. 2. ...
6 years, 9 months ago (2014-03-10 21:54:55 UTC) #2
ramant (doing other things)
Hi Wan-Teh, The following is the CL for histograms.xml (old habit of separating histogram.xml changes ...
6 years, 9 months ago (2014-03-10 22:01:29 UTC) #3
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-10 22:01:49 UTC) #4
ramant (doing other things)
https://codereview.chromium.org/192583005/diff/1/net/quic/quic_crypto_client_stream.cc File net/quic/quic_crypto_client_stream.cc (right): https://codereview.chromium.org/192583005/diff/1/net/quic/quic_crypto_client_stream.cc#newcode468 net/quic/quic_crypto_client_stream.cc:468: UMA_HISTOGRAM_TIMES("Net.QuicServerInfo.DiskCacheLoadTime", On 2014/03/10 21:54:55, wtc wrote: > > IMPORTANT: ...
6 years, 9 months ago (2014-03-10 22:02:07 UTC) #5
wtc
Patch set 2 LGTM.
6 years, 9 months ago (2014-03-10 22:15:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/192583005/20001
6 years, 9 months ago (2014-03-10 23:10:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/192583005/20001
6 years, 9 months ago (2014-03-11 00:03:27 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 07:55:53 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=279352
6 years, 9 months ago (2014-03-11 07:55:54 UTC) #10
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-11 17:06:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/192583005/20001
6 years, 9 months ago (2014-03-11 17:10:01 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 17:19:50 UTC) #13
Message was sent while issue was closed.
Change committed as 256262

Powered by Google App Engine
This is Rietveld 408576698