Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: net/quic/crypto/quic_server_info.h

Issue 192583004: QUIC - use QuicSessionKey tuple (host, port, is_https) instead of server_hostname (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: reupload Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/crypto/quic_server_info.h
diff --git a/net/quic/crypto/quic_server_info.h b/net/quic/crypto/quic_server_info.h
index 853504ae70f96882c3d1d5e66165097892554dc3..2fcc2bdb80d4d940ed646f6b86c428517bca7979 100644
--- a/net/quic/crypto/quic_server_info.h
+++ b/net/quic/crypto/quic_server_info.h
@@ -24,7 +24,7 @@ class X509Certificate;
// crypto config.
class NET_EXPORT_PRIVATE QuicServerInfo {
public:
- QuicServerInfo(const std::string& hostname);
+ QuicServerInfo(const std::string& hostname, uint16 port);
Ryan Hamilton 2014/03/10 20:57:33 nit: HostPortPair here and elsewhere? (excluding s
ramant (doing other things) 2014/03/11 00:48:50 Changed everywhere except shared code (and/or file
virtual ~QuicServerInfo();
// Start will commence the lookup. This must be called before any other
@@ -92,8 +92,10 @@ class NET_EXPORT_PRIVATE QuicServerInfo {
// SerializeInner is a helper function for Serialize.
std::string SerializeInner() const;
- // This is the QUIC server hostname for which we restore the crypto_config.
+ // This is the QUIC server hostname and port for which we restore the
+ // crypto_config.
const std::string hostname_;
+ uint16 port_;
};
class QuicServerInfoFactory {
@@ -101,8 +103,9 @@ class QuicServerInfoFactory {
virtual ~QuicServerInfoFactory();
// GetForHost returns a fresh, allocated QuicServerInfo for the given
- // hostname or NULL on failure.
- virtual QuicServerInfo* GetForHost(const std::string& hostname) = 0;
+ // hostname and port or NULL on failure.
+ virtual QuicServerInfo* GetForHost(const std::string& hostname,
Ryan Hamilton 2014/03/10 20:57:33 nit: GetForHostPort?
ramant (doing other things) 2014/03/11 00:48:50 Done.
+ uint16 port) = 0;
};
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698