Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Unified Diff: net/quic/quic_stream_factory.cc

Issue 192583004: QUIC - use QuicSessionKey tuple (host, port, is_https) instead of server_hostname (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use QuicSessionKey as arg and delete server_hostname as arg Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_stream_factory.cc
diff --git a/net/quic/quic_stream_factory.cc b/net/quic/quic_stream_factory.cc
index 95f15511f3560f40a1efa58c948f964fc2058a00..9342812b6f096ea51f846bce23de5c1f4da91b09 100644
--- a/net/quic/quic_stream_factory.cc
+++ b/net/quic/quic_stream_factory.cc
@@ -31,6 +31,7 @@
#include "net/quic/quic_default_packet_writer.h"
#include "net/quic/quic_http_stream.h"
#include "net/quic/quic_protocol.h"
+#include "net/quic/quic_session_key.h"
#include "net/socket/client_socket_factory.h"
using std::string;
@@ -653,8 +654,8 @@ int QuicStreamFactory::CreateSession(
*session = new QuicClientSession(
connection, socket.Pass(), writer.Pass(), this,
- quic_crypto_client_stream_factory_, host_port_pair.host(),
- config, crypto_config, net_log.net_log());
+ quic_crypto_client_stream_factory_, session_key, config, crypto_config,
+ net_log.net_log());
all_sessions_.insert(*session); // owning pointer
if (is_https) {
crypto_config->SetProofVerifier(
@@ -692,8 +693,7 @@ QuicCryptoClientConfig* QuicStreamFactory::GetOrCreateCryptoConfig(
crypto_config = new QuicCryptoClientConfig();
if (quic_server_info_factory_) {
QuicCryptoClientConfig::CachedState* cached =
- crypto_config->Create(session_key.host_port_pair().host(),
- quic_server_info_factory_);
+ crypto_config->Create(session_key, quic_server_info_factory_);
DCHECK(cached);
}
crypto_config->SetDefaults();
@@ -707,7 +707,6 @@ void QuicStreamFactory::PopulateFromCanonicalConfig(
const QuicSessionKey& session_key,
QuicCryptoClientConfig* crypto_config) {
const string server_hostname = session_key.host_port_pair().host();
- const uint16 server_port = session_key.host_port_pair().port();
unsigned i = 0;
for (; i < canoncial_suffixes_.size(); ++i) {
if (EndsWith(server_hostname, canoncial_suffixes_[i], false)) {
@@ -717,7 +716,8 @@ void QuicStreamFactory::PopulateFromCanonicalConfig(
if (i == canoncial_suffixes_.size())
return;
- HostPortPair suffix_host_port_pair(canoncial_suffixes_[i], server_port);
+ HostPortPair suffix_host_port_pair(canoncial_suffixes_[i],
+ session_key.host_port_pair().port());
QuicSessionKey suffix_session_key(suffix_host_port_pair,
session_key.is_https());
if (!ContainsKey(canonical_hostname_to_origin_map_, suffix_session_key)) {
@@ -732,13 +732,10 @@ void QuicStreamFactory::PopulateFromCanonicalConfig(
QuicCryptoClientConfig* canonical_crypto_config =
all_crypto_configs_[canonical_session_key];
DCHECK(canonical_crypto_config);
- const HostPortPair& canonical_host_port_pair =
- canonical_session_key.host_port_pair();
// Copy the CachedState for the canonical server from canonical_crypto_config
// as the initial CachedState for the server_hostname in crypto_config.
- crypto_config->InitializeFrom(server_hostname,
- canonical_host_port_pair.host(),
+ crypto_config->InitializeFrom(session_key, canonical_session_key,
canonical_crypto_config);
// Update canonical version to point at the "most recent" crypto_config.
canonical_hostname_to_origin_map_[suffix_session_key] =

Powered by Google App Engine
This is Rietveld 408576698