Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: net/quic/quic_crypto_client_stream.h

Issue 192583004: QUIC - use QuicSessionKey tuple (host, port, is_https) instead of server_hostname (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use QuicSessionKey as arg and delete server_hostname as arg Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_crypto_client_stream.h
diff --git a/net/quic/quic_crypto_client_stream.h b/net/quic/quic_crypto_client_stream.h
index 12198d94c32ff65506a4159e9b172f49d4145676..2cde4b15be08df6110621e66621b282ba970aad5 100644
--- a/net/quic/quic_crypto_client_stream.h
+++ b/net/quic/quic_crypto_client_stream.h
@@ -15,6 +15,7 @@
#include "net/quic/crypto/quic_crypto_client_config.h"
#include "net/quic/quic_config.h"
#include "net/quic/quic_crypto_stream.h"
+#include "net/quic/quic_session_key.h"
namespace net {
@@ -28,7 +29,7 @@ class CryptoTestUtils;
class NET_EXPORT_PRIVATE QuicCryptoClientStream : public QuicCryptoStream {
public:
- QuicCryptoClientStream(const string& server_hostname,
+ QuicCryptoClientStream(const QuicSessionKey& session_key,
QuicSession* session,
QuicCryptoClientConfig* crypto_config);
virtual ~QuicCryptoClientStream();
@@ -112,8 +113,8 @@ class NET_EXPORT_PRIVATE QuicCryptoClientStream : public QuicCryptoStream {
// Client's connection nonce (4-byte timestamp + 28 random bytes)
std::string nonce_;
- // Server's hostname
- std::string server_hostname_;
+ // Server's (is_https, hostname, port) tuple.
wtc 2014/03/13 22:22:03 Nit: same here -- might be better to list is_https
ramant (doing other things) 2014/03/13 23:46:36 Done.
+ const QuicSessionKey session_key_;
// Generation counter from QuicCryptoClientConfig's CachedState.
uint64 generation_counter_;

Powered by Google App Engine
This is Rietveld 408576698