Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: net/quic/quic_stream_factory_test.cc

Issue 192583004: QUIC - use QuicSessionKey tuple (host, port, is_https) instead of server_hostname (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comments from Patch set 1 and 3 and merge with TOT Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_stream_factory_test.cc
diff --git a/net/quic/quic_stream_factory_test.cc b/net/quic/quic_stream_factory_test.cc
index 203836f6ee4784566bcea19054e8dd1c47c40bc3..c4a26a93f60b07ad393cb8e2259130aed1e2b32c 100644
--- a/net/quic/quic_stream_factory_test.cc
+++ b/net/quic/quic_stream_factory_test.cc
@@ -1029,7 +1029,8 @@ TEST_P(QuicStreamFactoryTest, SharedCryptoConfig) {
&factory_, host_port_pair1, is_https_);
DCHECK(crypto_config1);
QuicCryptoClientConfig::CachedState* cached1 =
- crypto_config1->LookupOrCreate(host_port_pair1.host());
+ crypto_config1->LookupOrCreate(host_port_pair1.host(),
+ host_port_pair1.port());
EXPECT_FALSE(cached1->proof_valid());
EXPECT_TRUE(cached1->source_address_token().empty());
@@ -1044,7 +1045,8 @@ TEST_P(QuicStreamFactoryTest, SharedCryptoConfig) {
&factory_, host_port_pair2, is_https_);
DCHECK(crypto_config2);
QuicCryptoClientConfig::CachedState* cached2 =
- crypto_config2->LookupOrCreate(host_port_pair2.host());
+ crypto_config2->LookupOrCreate(host_port_pair2.host(),
+ host_port_pair2.port());
EXPECT_EQ(cached1->source_address_token(), cached2->source_address_token());
EXPECT_TRUE(cached2->proof_valid());
}
@@ -1067,7 +1069,8 @@ TEST_P(QuicStreamFactoryTest, CryptoConfigWhenProofIsInvalid) {
&factory_, host_port_pair1, is_https_);
DCHECK(crypto_config1);
QuicCryptoClientConfig::CachedState* cached1 =
- crypto_config1->LookupOrCreate(host_port_pair1.host());
+ crypto_config1->LookupOrCreate(host_port_pair1.host(),
+ host_port_pair1.port());
EXPECT_FALSE(cached1->proof_valid());
EXPECT_TRUE(cached1->source_address_token().empty());
@@ -1082,7 +1085,8 @@ TEST_P(QuicStreamFactoryTest, CryptoConfigWhenProofIsInvalid) {
&factory_, host_port_pair2, is_https_);
DCHECK(crypto_config2);
QuicCryptoClientConfig::CachedState* cached2 =
- crypto_config2->LookupOrCreate(host_port_pair2.host());
+ crypto_config2->LookupOrCreate(host_port_pair2.host(),
+ host_port_pair2.port());
EXPECT_NE(cached1->source_address_token(), cached2->source_address_token());
EXPECT_TRUE(cached2->source_address_token().empty());
EXPECT_FALSE(cached2->proof_valid());

Powered by Google App Engine
This is Rietveld 408576698