Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: net/quic/crypto/quic_server_info.h

Issue 192583004: QUIC - use QuicSessionKey tuple (host, port, is_https) instead of server_hostname (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comments from Patch set 1 and 3 and merge with TOT Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/crypto/quic_server_info.h
diff --git a/net/quic/crypto/quic_server_info.h b/net/quic/crypto/quic_server_info.h
index 853504ae70f96882c3d1d5e66165097892554dc3..491b31860a0311edc3153e023af0a377a5ebe8f8 100644
--- a/net/quic/crypto/quic_server_info.h
+++ b/net/quic/crypto/quic_server_info.h
@@ -12,6 +12,7 @@
#include "base/memory/weak_ptr.h"
#include "base/time/time.h"
#include "net/base/completion_callback.h"
+#include "net/base/host_port_pair.h"
#include "net/base/net_export.h"
namespace net {
@@ -24,7 +25,7 @@ class X509Certificate;
// crypto config.
class NET_EXPORT_PRIVATE QuicServerInfo {
public:
- QuicServerInfo(const std::string& hostname);
+ QuicServerInfo(const HostPortPair& host_port_pair);
virtual ~QuicServerInfo();
// Start will commence the lookup. This must be called before any other
@@ -92,17 +93,19 @@ class NET_EXPORT_PRIVATE QuicServerInfo {
// SerializeInner is a helper function for Serialize.
std::string SerializeInner() const;
- // This is the QUIC server hostname for which we restore the crypto_config.
- const std::string hostname_;
+ // This is the QUIC server HostPortPair for which we restore the
+ // crypto_config.
+ const HostPortPair host_port_pair_;
};
class QuicServerInfoFactory {
public:
virtual ~QuicServerInfoFactory();
- // GetForHost returns a fresh, allocated QuicServerInfo for the given
- // hostname or NULL on failure.
- virtual QuicServerInfo* GetForHost(const std::string& hostname) = 0;
+ // GetForHostPort returns a fresh, allocated QuicServerInfo for the given
+ // |host_port_pair| or NULL on failure.
+ virtual QuicServerInfo* GetForHostPortPair(
wtc 2014/03/11 01:41:39 Nit: consider naming this method "GetForServer".
ramant (doing other things) 2014/03/13 01:50:12 Done.
+ const HostPortPair& host_port_pair) = 0;
};
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698