Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: net/http/disk_cache_based_quic_server_info_unittest.cc

Issue 192583004: QUIC - use QuicSessionKey tuple (host, port, is_https) instead of server_hostname (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/disk_cache_based_quic_server_info_unittest.cc
diff --git a/net/http/disk_cache_based_quic_server_info_unittest.cc b/net/http/disk_cache_based_quic_server_info_unittest.cc
index 4e4591f8da373a08a4d033c64e49373fb58c542d..b233d4c31716fe62e79b96cf46554a03fd24ea64 100644
--- a/net/http/disk_cache_based_quic_server_info_unittest.cc
+++ b/net/http/disk_cache_based_quic_server_info_unittest.cc
@@ -17,7 +17,7 @@ namespace {
// This is an empty transaction, needed to register the URL and the test mode.
const MockTransaction kHostInfoTransaction = {
- "quicserverinfo:https://www.google.com",
+ "quicserverinfo:https://www.google.com/443",
"",
base::Time(),
"",
@@ -40,6 +40,7 @@ TEST(DiskCacheBasedQuicServerInfo, DeleteInCallback) {
MockHttpCache cache(factory);
scoped_ptr<net::QuicServerInfo> quic_server_info(
new net::DiskCacheBasedQuicServerInfo("https://www.verisign.com",
+ 443,
Ryan Hamilton 2014/03/10 20:57:33 Should we have any test which demonstrates differe
ramant (doing other things) 2014/03/11 00:48:50 Done.
cache.http_cache()));
quic_server_info->Start();
net::TestCompletionCallback callback;
@@ -58,6 +59,7 @@ TEST(DiskCacheBasedQuicServerInfo, Update) {
scoped_ptr<net::QuicServerInfo> quic_server_info(
new net::DiskCacheBasedQuicServerInfo("https://www.google.com",
+ 443,
cache.http_cache()));
quic_server_info->Start();
int rv = quic_server_info->WaitForDataReady(callback.callback());
@@ -83,6 +85,7 @@ TEST(DiskCacheBasedQuicServerInfo, Update) {
// Open the stored QuicServerInfo.
quic_server_info.reset(
new net::DiskCacheBasedQuicServerInfo("https://www.google.com",
+ 443,
cache.http_cache()));
quic_server_info->Start();
rv = quic_server_info->WaitForDataReady(callback.callback());
@@ -100,6 +103,7 @@ TEST(DiskCacheBasedQuicServerInfo, Update) {
// Verify that the state was updated.
quic_server_info.reset(
new net::DiskCacheBasedQuicServerInfo("https://www.google.com",
+ 443,
cache.http_cache()));
quic_server_info->Start();
rv = quic_server_info->WaitForDataReady(callback.callback());

Powered by Google App Engine
This is Rietveld 408576698