QUIC - use QuicSessionKey tuple (host, port, is_https) instead of server_hostname

net/tools/quic/test_tools/quic_test_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/tools/quic/test_tools/quic_test_client.h"
 
 #include "base/time/time.h"
 #include "net/base/completion_callback.h"
 #include "net/base/net_errors.h"
 #include "net/cert/cert_verify_result.h"
@@ skipping 273 matching lines @@
 QuicClient* QuicTestClient::client() { return client_.get(); }
 
 const string& QuicTestClient::cert_common_name() const {
   return reinterpret_cast<RecordingProofVerifier*>(proof_verifier_)
       ->common_name();
 }
 
 QuicTagValueMap QuicTestClient::GetServerConfig() const {
   net::QuicCryptoClientConfig* config =
       QuicClientPeer::GetCryptoConfig(client_.get());
+  // Defaulting server port to 9999.
   net::QuicCryptoClientConfig::CachedState* state =
-      config->LookupOrCreate(client_->server_hostname());
+      config->LookupOrCreate(client_->server_hostname(), 9999);

[ramant (doing other things), 2014/03/10 20:31:46]

We are not passing port for QuiTestClient and this code doesn't use chrome's
disk_cache (quic_server_info_factory is not initialized). Should we default to
port 0??

[ramant (doing other things), 2014/03/11 00:48:50]

Using the port from client's server_address.

   const net::CryptoHandshakeMessage* handshake_msg = state->GetServerConfig();
   if (handshake_msg != NULL) {
     return handshake_msg->tag_value_map();
   } else {
     return QuicTagValueMap();
   }
 }
 
 bool QuicTestClient::connected() const {
   return client_->connected();
@@ skipping 149 matching lines @@
 
 void QuicTestClient::WaitForWriteToFlush() {
   while (connected() && client()->session()->HasDataToWrite()) {
     client_->WaitForEvents();
   }
 }
 
 }  // namespace test
 }  // namespace tools
 }  // namespace net