QUIC - use QuicSessionKey tuple (host, port, is_https) instead of server_hostname

net/tools/quic/quic_client_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/tools/quic/quic_client_session.h"
 
 #include "base/logging.h"
 #include "net/quic/crypto/crypto_protocol.h"
 #include "net/tools/quic/quic_spdy_client_stream.h"
 
 using std::string;
 
 namespace net {
 namespace tools {
 
 QuicClientSession::QuicClientSession(
     const string& server_hostname,
     const QuicConfig& config,
     QuicConnection* connection,
     QuicCryptoClientConfig* crypto_config)
     : QuicSession(connection, config),
-      crypto_stream_(server_hostname, this, crypto_config) {
+      // Defaulting server_port to 9999.

[ramant (doing other things), 2014/03/10 20:31:46]

We are not passing port for QuiClientSession and this code doesn't use chrome's
disk_cache (quic_server_info_factory is not initialized). Should we default to
port 0??

[ramant (doing other things), 2014/03/11 00:48:50]

Using the port from connection.

+      crypto_stream_(server_hostname, 9999, this, crypto_config) {
 }
 
 QuicClientSession::~QuicClientSession() {
 }
 
 QuicSpdyClientStream* QuicClientSession::CreateOutgoingDataStream() {
   if (!crypto_stream_.encryption_established()) {
     DVLOG(1) << "Encryption not active so no outgoing stream created.";
     return NULL;
   }
@@ skipping 26 matching lines @@
 }
 
 QuicDataStream* QuicClientSession::CreateIncomingDataStream(
     QuicStreamId id) {
   DLOG(ERROR) << "Server push not supported";
   return NULL;
 }
 
 }  // namespace tools
 }  // namespace net