QUIC - use QuicSessionKey tuple (host, port, is_https) instead of server_hostname

net/quic/quic_client_session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A client specific QuicSession subclass.  This class owns the underlying
 // QuicConnection and QuicConnectionHelper objects.  The connection stores
 // a non-owning pointer to the helper so this session needs to ensure that
 // the helper outlives the connection.
 
 #ifndef NET_QUIC_QUIC_CLIENT_SESSION_H_
@@ skipping 11 matching lines @@
 #include "net/quic/quic_protocol.h"
 #include "net/quic/quic_reliable_client_stream.h"
 #include "net/quic/quic_session.h"
 
 namespace net {
 
 class DatagramClientSocket;
 class QuicConnectionHelper;
 class QuicCryptoClientStreamFactory;
 class QuicDefaultPacketWriter;
+class QuicSessionKey;
 class QuicStreamFactory;
 class SSLInfo;
 
 namespace test {
 class QuicClientSessionPeer;
 }  // namespace test
 
 class NET_EXPORT_PRIVATE QuicClientSession : public QuicSession {
  public:
   // An interface for observing events on a session.
@@ skipping 43 matching lines @@
 
   // Constructs a new session which will own |connection| and |helper|, but
   // not |stream_factory|, which must outlive this session.
   // TODO(rch): decouple the factory from the session via a Delegate interface.
   QuicClientSession(QuicConnection* connection,
                     scoped_ptr<DatagramClientSocket> socket,
                     scoped_ptr<QuicDefaultPacketWriter> writer,
                     QuicStreamFactory* stream_factory,
                     scoped_ptr<QuicServerInfo> server_info,
                     QuicCryptoClientStreamFactory* crypto_client_stream_factory,
-                    const std::string& server_hostname,
+                    const QuicSessionKey& server_key,

[wtc, 2014/03/17 17:13:21]

Nit: server_info and server_key probably should be listed next to each other.

[ramant (doing other things), 2014/03/17 18:27:36]

Fixed it in https://codereview.chromium.org/202143004

Done.

                     const QuicConfig& config,
                     QuicCryptoClientConfig* crypto_config,
                     NetLog* net_log);
 
   virtual ~QuicClientSession();
 
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
   // Attempts to create a new stream.  If the stream can be
@@ skipping 114 matching lines @@
   // Number of packets read in the current read loop.
   size_t num_packets_read_;
   base::WeakPtrFactory<QuicClientSession> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicClientSession);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_CLIENT_SESSION_H_