Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1925803005: [runtime] Don't crash when creating an instance of a class inherited from a Proxy. (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Don't crash when creating an instance of a class inherited from a Proxy. BUG=v8:4972 LOG=N Committed: https://crrev.com/b83edcc8b1a7bddee35bb47bad1cf4eafb726843 Cr-Commit-Position: refs/heads/master@{#35911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/objects.cc View 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-v8-4972.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925803005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925803005/1
4 years, 7 months ago (2016-04-29 14:20:22 UTC) #2
Igor Sheludko
PTALnCQ
4 years, 7 months ago (2016-04-29 14:20:28 UTC) #4
Jakob Kummerow
lgtm
4 years, 7 months ago (2016-04-29 15:04:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925803005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925803005/1
4 years, 7 months ago (2016-04-29 15:04:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 15:07:05 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b83edcc8b1a7bddee35bb47bad1cf4eafb726843
Cr-Commit-Position: refs/heads/master@{#35911}

Powered by Google App Engine
This is Rietveld 408576698