Add sk_sp to SkSurface_Gpu and SkGpuDevice

Add sk_sp to SkSurface_Gpu and SkGpuDevice

Split off of https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice)

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1925803004

Committed: https://skia.googlesource.com/skia/+/24e912869499352e8947d3943acb43edd7ffded6

[robertphillips, 2016-04-28 21:35:13]

Description was changed from

==========
Add sk_sp to SkSurface_Gpu and SkGpuDevice

Split off of https://codereview.chromium.org/1930013002/ ((Mostly) Retract
GrRenderTarget from SkGpuDevice)
==========

to

==========
Add sk_sp to SkSurface_Gpu and SkGpuDevice

Split off of https://codereview.chromium.org/1930013002/ ((Mostly) Retract
GrRenderTarget from SkGpuDevice)
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-28 21:39:27]

Description was changed from

==========
Add sk_sp to SkSurface_Gpu and SkGpuDevice

Split off of https://codereview.chromium.org/1930013002/ ((Mostly) Retract
GrRenderTarget from SkGpuDevice)
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add sk_sp to SkSurface_Gpu and SkGpuDevice

Split off of https://codereview.chromium.org/1930013002/ ((Mostly) Retract
GrRenderTarget from SkGpuDevice)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-28 21:39:27]

robertphillips@google.com changed reviewers:
+ fmalita@chromium.org, reed@google.com

[robertphillips, 2016-04-28 21:39:34]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 21:39:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925803004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925803004/1

[commit-bot: I haz the power, 2016-04-28 21:42:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 21:42:12]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[robertphillips, 2016-04-28 21:42:40]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2016-04-28 21:56:12]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 21:56:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925803004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925803004/1

[commit-bot: I haz the power, 2016-04-28 21:59:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 21:59:05]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[robertphillips, 2016-04-28 22:25:10]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 22:25:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925803004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925803004/1

[commit-bot: I haz the power, 2016-04-28 22:26:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 22:26:52]

Dry run: Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[robertphillips, 2016-04-28 22:29:14]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 22:29:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925803004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925803004/1

[commit-bot: I haz the power, 2016-04-28 22:30:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 22:30:12]

Dry run: Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[f(malita), 2016-04-29 01:45:16]

LGTM w/ nits

https://codereview.chromium.org/1925803004/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1925803004/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:132: return SkGpuDevice::Make(rt, rt->width(),
rt->height(), props, init);
std::move(rt)

https://codereview.chromium.org/1925803004/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:144: return sk_sp<SkGpuDevice>(new SkGpuDevice(rt.get(),
width, height, props, flags));
sk_make_sp<SkGpuDevice>(...)

https://codereview.chromium.org/1925803004/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:160: return sk_sp<SkGpuDevice>(new SkGpuDevice(rt,
info.width(), info.height(), props, flags));
ditto

[f(malita), 2016-04-29 01:51:53]

https://codereview.chromium.org/1925803004/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1925803004/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:132: return SkGpuDevice::Make(rt, rt->width(),
rt->height(), props, init);
On 2016/04/29 01:45:16, f(malita) wrote:
> std::move(rt)

(better grab width/height before the call too if we do this:)

[robertphillips, 2016-04-29 12:20:11]

https://codereview.chromium.org/1925803004/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1925803004/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:132: return SkGpuDevice::Make(rt, rt->width(),
rt->height(), props, init);
On 2016/04/29 01:51:53, f(malita) wrote:
> On 2016/04/29 01:45:16, f(malita) wrote:
> > std::move(rt)
> 
> (better grab width/height before the call too if we do this:)

Done.

https://codereview.chromium.org/1925803004/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:132: return SkGpuDevice::Make(rt, rt->width(),
rt->height(), props, init);
On 2016/04/29 01:45:16, f(malita) wrote:
> std::move(rt)

Done.

https://codereview.chromium.org/1925803004/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:144: return sk_sp<SkGpuDevice>(new SkGpuDevice(rt.get(),
width, height, props, flags));
On 2016/04/29 01:45:16, f(malita) wrote:
> sk_make_sp<SkGpuDevice>(...)

SkGpuDevice's ctor is private so the sk_make_sp syntax doesn't work.

https://codereview.chromium.org/1925803004/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:160: return sk_sp<SkGpuDevice>(new SkGpuDevice(rt,
info.width(), info.height(), props, flags));
On 2016/04/29 01:45:16, f(malita) wrote:
> ditto

Same here.

[robertphillips, 2016-04-29 12:20:53]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 12:20:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925803004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925803004/20001

[commit-bot: I haz the power, 2016-04-29 13:41:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 13:41:28]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-29 13:42:46]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-04-29 13:42:46]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1925803004/#ps20001
(title: "Address code review issues")

[commit-bot: I haz the power, 2016-04-29 13:42:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925803004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925803004/20001

[commit-bot: I haz the power, 2016-04-29 13:46:40]

Description was changed from

==========
Add sk_sp to SkSurface_Gpu and SkGpuDevice

Split off of https://codereview.chromium.org/1930013002/ ((Mostly) Retract
GrRenderTarget from SkGpuDevice)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add sk_sp to SkSurface_Gpu and SkGpuDevice

Split off of https://codereview.chromium.org/1930013002/ ((Mostly) Retract
GrRenderTarget from SkGpuDevice)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/24e912869499352e8947d3943acb43edd7ffded6
==========

[commit-bot: I haz the power, 2016-04-29 13:46:41]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/24e912869499352e8947d3943acb43edd7ffded6