Rename NotificationUIManagerMac to NotificationPlatformBridgeMac

Rename NotificationUIManagerMac to NotificationPlatformBridgeMac

Also remove the now unused CreateNativeNotificationManager method.

BUG=596161
Committed: https://crrev.com/ba21b8d02d2932a2a023c2972c97ce388c4e47c1
Cr-Commit-Position: refs/heads/master@{#390218}

[Miguel Garcia, 2016-04-27 21:13:29]

Description was changed from

==========
mac rename

BUG=
==========

to

==========
Rename NotificationUIManagerMac to NotificationPlatformBridgeMac

BUG=596161
==========

[Miguel Garcia, 2016-04-27 21:20:39]

miguelg@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2016-04-27 21:26:59]

lgtm % nits

https://codereview.chromium.org/1925803002/diff/1/chrome/browser/notification...
File chrome/browser/notifications/message_center_notification_manager.cc (left):

https://codereview.chromium.org/1925803002/diff/1/chrome/browser/notification...
chrome/browser/notifications/message_center_notification_manager.cc:52:
NotificationUIManager::CreateNativeNotificationManager() {
Please remove the declaration from notification_ui_manager.h as well.

https://codereview.chromium.org/1925803002/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_platform_bridge_mac.h (right):

https://codereview.chromium.org/1925803002/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_mac.h:20: // This
class is an implementation of NotificationPlatfrormBridge that will
nit: Platfrorm -> Platform

https://codereview.chromium.org/1925803002/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_platform_bridge_mac.mm (right):

https://codereview.chromium.org/1925803002/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_mac.mm:86: const
std::string& profile_id,
nit: alignment

https://codereview.chromium.org/1925803002/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_mac.mm:182:
notification.delegate()->Display();
Merge conflict? You unified this in the display manager.

https://codereview.chromium.org/1925803002/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_mac.mm:186: const
std::string& notification_id) {
nit: alignment

[Miguel Garcia, 2016-04-27 21:34:13]

Description was changed from

==========
Rename NotificationUIManagerMac to NotificationPlatformBridgeMac

BUG=596161
==========

to

==========
Rename NotificationUIManagerMac to NotificationPlatformBridgeMac

Also remove the now unused CreateNativeNotificationManager method.

BUG=596161
==========

[Miguel Garcia, 2016-04-27 21:35:31]

The CQ bit was checked by miguelg@chromium.org

[Miguel Garcia, 2016-04-27 21:35:32]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1925803002/#ps20001
(title: " ")

[Miguel Garcia, 2016-04-27 21:35:42]

Thanks for the speedy review!

https://chromiumcodereview.appspot.com/1925803002/diff/1/chrome/browser/notif...
File chrome/browser/notifications/message_center_notification_manager.cc (left):

https://chromiumcodereview.appspot.com/1925803002/diff/1/chrome/browser/notif...
chrome/browser/notifications/message_center_notification_manager.cc:52:
NotificationUIManager::CreateNativeNotificationManager() {
On 2016/04/27 21:26:58, Peter Beverloo wrote:
> Please remove the declaration from notification_ui_manager.h as well.

Done.

https://chromiumcodereview.appspot.com/1925803002/diff/1/chrome/browser/notif...
File chrome/browser/notifications/notification_platform_bridge_mac.h (right):

https://chromiumcodereview.appspot.com/1925803002/diff/1/chrome/browser/notif...
chrome/browser/notifications/notification_platform_bridge_mac.h:20: // This
class is an implementation of NotificationPlatfrormBridge that will
On 2016/04/27 21:26:58, Peter Beverloo wrote:
> nit: Platfrorm -> Platform

Done.

https://chromiumcodereview.appspot.com/1925803002/diff/1/chrome/browser/notif...
File chrome/browser/notifications/notification_platform_bridge_mac.mm (right):

https://chromiumcodereview.appspot.com/1925803002/diff/1/chrome/browser/notif...
chrome/browser/notifications/notification_platform_bridge_mac.mm:86: const
std::string& profile_id,
On 2016/04/27 21:26:58, Peter Beverloo wrote:
> nit: alignment

Done.

https://chromiumcodereview.appspot.com/1925803002/diff/1/chrome/browser/notif...
chrome/browser/notifications/notification_platform_bridge_mac.mm:182:
notification.delegate()->Display();
On 2016/04/27 21:26:58, Peter Beverloo wrote:
> Merge conflict? You unified this in the display manager.

mm yes I don't know how this one sneaked in. Will double check the rebase.
Thanks for spotting it!

https://chromiumcodereview.appspot.com/1925803002/diff/1/chrome/browser/notif...
chrome/browser/notifications/notification_platform_bridge_mac.mm:186: const
std::string& notification_id) {
On 2016/04/27 21:26:58, Peter Beverloo wrote:
> nit: alignment

Done.

[commit-bot: I haz the power, 2016-04-27 21:35:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925803002/20001

[commit-bot: I haz the power, 2016-04-27 22:33:15]

Description was changed from

==========
Rename NotificationUIManagerMac to NotificationPlatformBridgeMac

Also remove the now unused CreateNativeNotificationManager method.

BUG=596161
==========

to

==========
Rename NotificationUIManagerMac to NotificationPlatformBridgeMac

Also remove the now unused CreateNativeNotificationManager method.

BUG=596161
==========

[commit-bot: I haz the power, 2016-04-27 22:33:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:14:02]

Patchset 2 (id:??) landed as
https://crrev.com/ba21b8d02d2932a2a023c2972c97ce388c4e47c1
Cr-Commit-Position: refs/heads/master@{#390218}

[commit-bot: I haz the power, 2016-04-30 17:52:31]

Description was changed from

==========
Rename NotificationUIManagerMac to NotificationPlatformBridgeMac

Also remove the now unused CreateNativeNotificationManager method.

BUG=596161
==========

to

==========
Rename NotificationUIManagerMac to NotificationPlatformBridgeMac

Also remove the now unused CreateNativeNotificationManager method.

BUG=596161

Committed: https://crrev.com/ba21b8d02d2932a2a023c2972c97ce388c4e47c1
Cr-Commit-Position: refs/heads/master@{#390218}
==========