Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc

Issue 1925733005: Remove people search (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Deprecate people search actions and enum Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/app_list/search/people/people_provider.cc ('k') | chrome/browser/ui/app_list/search/people/people_result.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc
diff --git a/chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc b/chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc
deleted file mode 100644
index ea5509a6ec6cff24d265033c1cd11f96e9b74da6..0000000000000000000000000000000000000000
--- a/chrome/browser/ui/app_list/search/people/people_provider_browsertest.cc
+++ /dev/null
@@ -1,292 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/ui/app_list/search/people/people_provider.h"
-
-#include <stddef.h>
-
-#include <memory>
-#include <string>
-#include <utility>
-
-#include "base/bind.h"
-#include "base/command_line.h"
-#include "base/macros.h"
-#include "base/run_loop.h"
-#include "base/strings/utf_string_conversions.h"
-#include "chrome/browser/profiles/profile_manager.h"
-#include "chrome/browser/ui/app_list/test/test_app_list_controller_delegate.h"
-#include "chrome/common/chrome_switches.h"
-#include "chrome/test/base/in_process_browser_test.h"
-#include "content/public/browser/browser_thread.h"
-#include "net/test/embedded_test_server/embedded_test_server.h"
-#include "net/test/embedded_test_server/http_request.h"
-#include "net/test/embedded_test_server/http_response.h"
-#include "ui/app_list/search_result.h"
-
-using content::BrowserThread;
-using net::test_server::BasicHttpResponse;
-using net::test_server::HttpRequest;
-using net::test_server::HttpResponse;
-
-namespace app_list {
-namespace test {
-namespace {
-
-// Mock results.
-const char kOneResult[] = "{"
- "\"items\":["
- "{"
- "\"person\" : {"
- "\"id\": \"1\","
- "\"metadata\" : {"
- "\"ownerId\": \"1\""
- "},"
- "\"names\" : [{"
- "\"displayName\": \"first person\""
- "}],"
- "\"emails\" : [{"
- "\"value\": \"first@person.com\""
- "}],"
- "\"images\" : [{"
- "\"url\": \"http://host/icon\""
- "}],"
- "\"sortKeys\" : {"
- "\"interactionRank\": \"0.98\""
- "}"
- "}"
- "}"
- "]}";
-
-const char kThreeValidResults[] = "{"
- "\"items\":["
- "{"
- "\"person\" : {"
- "\"id\": \"1\","
- "\"metadata\" : {"
- "\"ownerId\": \"1\""
- "},"
- "\"names\" : [{"
- "\"displayName\": \"first person\""
- "}],"
- "\"emails\" : [{"
- "\"value\": \"first@person.com\""
- "}],"
- "\"images\" : [{"
- "\"url\": \"http://host/icon\""
- "}],"
- "\"sortKeys\" : {"
- "\"interactionRank\": \"0.98\""
- "}"
- "}"
- "},"
- "{"
- "\"person\" : {"
- "\"id\": \"2\","
- "\"metadata\" : {"
- "\"ownerId\": \"37\""
- "},"
- "\"names\" : [{"
- "\"displayName\": \"second person\""
- "}],"
- "\"emails\" : [{"
- "\"value\": \"second@person.com\""
- "}],"
- "\"images\" : [{"
- "\"url\": \"http://host/icon\""
- "}],"
- "\"sortKeys\" : {"
- "\"interactionRank\": \"0.84\""
- "}"
- "}"
- "},"
- "{"
- "\"person\" : {"
- "\"id\": \"3\","
- "\"metadata\" : {"
- "\"ownerId\": \"3\""
- "},"
- "\"names\" : [{"
- "\"displayName\": \"third person\""
- "}],"
- "\"emails\" : [{"
- "\"value\": \"third@person.com\""
- "}],"
- "\"images\" : [{"
- "\"url\": \"http://host/icon\""
- "}],"
- "\"sortKeys\" : {"
- "\"interactionRank\": \"0.67\""
- "}"
- "}"
- "},"
- "{"
- "\"person\" : {"
- "\"id\": \"4\","
- "\"metadata\" : {"
- "\"ownerId\": \"4\""
- "},"
- "\"names\" : [{"
- "\"displayName\": \"fourth person\""
- "}],"
- "\"emails\" : [{"
- "\"value\": \"fourth@person.com\""
- "}],"
- "\"images\" : [{"
- "\"url\": \"http://host/icon\""
- "}],"
- "\"sortKeys\" : {"
- "\"interactionRank\": \"0.0\""
- "}"
- "}"
- "},"
- "{"
- "\"person\" : {"
- "\"id\": \"5\","
- "\"metadata\" : {"
- "\"ownerId\": \"5\""
- "},"
- "\"names\" : [{"
- "\"displayName\": \"fifth person\""
- "}],"
- "\"emails\" : [{"
- "\"value\": \"fifth@person.com\""
- "}],"
- // Images field is missing on purpose.
- "\"sortKeys\" : {"
- "\"interactionRank\": \"0.98\""
- "}"
- "}"
- "}"
- "]}";
-
-} // namespace
-
-class PeopleProviderTest : public InProcessBrowserTest {
- public:
- PeopleProviderTest() {}
- ~PeopleProviderTest() override {}
-
- // InProcessBrowserTest overrides:
- void SetUpOnMainThread() override {
- embedded_test_server()->RegisterRequestHandler(
- base::Bind(&PeopleProviderTest::HandleRequest,
- base::Unretained(this)));
- ASSERT_TRUE(embedded_test_server()->Start());
-
- people_provider_.reset(new PeopleProvider(
- ProfileManager::GetActiveUserProfile(), &test_controller_));
-
- people_provider_->SetupForTest(
- base::Bind(&PeopleProviderTest::OnSearchResultsFetched,
- base::Unretained(this)),
- embedded_test_server()->base_url());
- people_provider_->set_use_throttling(false);
- }
-
- std::string RunQuery(const std::string& query,
- const std::string& mock_server_response) {
- people_provider_->Start(false, base::UTF8ToUTF16(query));
-
- if (people_provider_->people_search_ && !mock_server_response.empty()) {
- mock_server_response_ = mock_server_response;
-
- DCHECK(!run_loop_);
- run_loop_.reset(new base::RunLoop);
- run_loop_->Run();
- run_loop_.reset();
-
- mock_server_response_.clear();
- }
-
- people_provider_->Stop();
- return GetResults();
- }
-
- std::string GetResults() const {
- std::string results;
- for (SearchProvider::Results::const_iterator it =
- people_provider_->results().begin();
- it != people_provider_->results().end();
- ++it) {
- if (!results.empty())
- results += ',';
- results += base::UTF16ToUTF8((*it)->title());
- }
- return results;
- }
-
- PeopleProvider* people_provider() { return people_provider_.get(); }
-
- private:
- std::unique_ptr<HttpResponse> HandleRequest(const HttpRequest& request) {
- std::unique_ptr<BasicHttpResponse> response(new BasicHttpResponse);
- response->set_code(net::HTTP_OK);
- response->set_content(mock_server_response_);
-
- return std::move(response);
- }
-
- void OnSearchResultsFetched() {
- if (run_loop_)
- run_loop_->Quit();
- }
-
- std::unique_ptr<base::RunLoop> run_loop_;
-
- std::string mock_server_response_;
-
- std::unique_ptr<PeopleProvider> people_provider_;
- ::test::TestAppListControllerDelegate test_controller_;
-
- DISALLOW_COPY_AND_ASSIGN(PeopleProviderTest);
-};
-
-IN_PROC_BROWSER_TEST_F(PeopleProviderTest, Basic) {
- struct {
- const char* query;
- const char* mock_server_response;
- const char* expected_results_content;
- } kTestCases[] = {
- {"first", kOneResult, "first person" },
- {"person", kThreeValidResults, "first person,second person,third person" },
- };
-
- for (size_t i = 0; i < arraysize(kTestCases); ++i) {
- EXPECT_EQ(kTestCases[i].expected_results_content,
- RunQuery(kTestCases[i].query,
- kTestCases[i].mock_server_response))
- << "Case " << i << ": q=" << kTestCases[i].query;
- }
-}
-
-IN_PROC_BROWSER_TEST_F(PeopleProviderTest, NoSearchForSensitiveData) {
- // None of the following input strings should be accepted because they may
- // contain private data.
- const char* inputs[] = {
- // file: scheme is bad.
- "file://filename",
- "FILE://filename",
- // URLs with usernames, ports, queries or refs are bad.
- "http://username:password@hostname/",
- "http://www.example.com:1000",
- "http://foo:1000",
- "http://hostname/?query=q",
- "http://hostname/path#ref",
- // A https URL with path is bad.
- "https://hostname/path",
- };
-
- for (size_t i = 0; i < arraysize(inputs); ++i)
- EXPECT_EQ("", RunQuery(inputs[i], kOneResult));
-}
-
-IN_PROC_BROWSER_TEST_F(PeopleProviderTest, NoSearchForShortQueries) {
- EXPECT_EQ("", RunQuery("f", kOneResult));
- EXPECT_EQ("", RunQuery("fi", kOneResult));
- EXPECT_EQ("first person", RunQuery("fir", kOneResult));
-}
-
-} // namespace test
-} // namespace app_list
« no previous file with comments | « chrome/browser/ui/app_list/search/people/people_provider.cc ('k') | chrome/browser/ui/app_list/search/people/people_result.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698