Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 192573004: Mark mjsunit/string-case as flaky. (Closed)

Created:
6 years, 9 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Mark mjsunit/string-case as flaky. BUG=v8:3208 LOG=N R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19760

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dmitry Lomov (no reviews)
6 years, 9 months ago (2014-03-10 10:48:08 UTC) #1
Michael Achenbach
https://codereview.chromium.org/192573004/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/192573004/diff/1/test/mjsunit/mjsunit.status#newcode142 test/mjsunit/mjsunit.status:142: ['gc_stress == True', { I wouldn't start a duplicate ...
6 years, 9 months ago (2014-03-10 12:37:27 UTC) #2
Dmitry Lomov (no reviews)
PTAL
6 years, 9 months ago (2014-03-10 14:06:27 UTC) #3
Michael Achenbach
lgtm
6 years, 9 months ago (2014-03-10 14:13:15 UTC) #4
Dmitry Lomov (no reviews)
6 years, 9 months ago (2014-03-10 14:52:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19760 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698