Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1925703003: Set needsPaintPhaseDescendantBlockBackgrounds if a table has collapsed borders (Closed)

Created:
4 years, 7 months ago by Xianzhu
Modified:
4 years, 7 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set needsPaintPhaseDescendantBlockBackgrounds if a table has collapsed borders No matter the actual borders are defined by which descendants and whether the descedants have self-painting layer, a border-collapsing table always paint collapsed borders in PaintPhaseDescendantBlockBackgrounds. Set needsPaintPhaseDescendantBlockBackgrounds if a table has visible collapsed borders. BUG=607022 TEST=PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds Committed: https://crrev.com/ca106e2693d28e0d045a82077e3a6d8d14c2df43 Cr-Commit-Position: refs/heads/master@{#390242}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Add a dynamic test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInfo.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp View 1 2 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Xianzhu
Hope this is the last bug of empty paint phase optimization.
4 years, 7 months ago (2016-04-27 17:38:00 UTC) #2
chrishtr
https://codereview.chromium.org/1925703003/diff/20001/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp File third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp (right): https://codereview.chromium.org/1925703003/diff/20001/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp#newcode520 third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp:520: EXPECT_TRUE(layer.needsPaintPhaseDescendantBlockBackgrounds()); Also test that adding the property resuts in ...
4 years, 7 months ago (2016-04-27 19:57:22 UTC) #3
Xianzhu
https://codereview.chromium.org/1925703003/diff/20001/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp File third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp (right): https://codereview.chromium.org/1925703003/diff/20001/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp#newcode520 third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp:520: EXPECT_TRUE(layer.needsPaintPhaseDescendantBlockBackgrounds()); On 2016/04/27 19:57:22, chrishtr wrote: > Also test ...
4 years, 7 months ago (2016-04-27 22:08:38 UTC) #4
chrishtr
lgtm
4 years, 7 months ago (2016-04-27 22:10:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925703003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925703003/40001
4 years, 7 months ago (2016-04-27 22:10:51 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-27 23:53:20 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:14:38 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ca106e2693d28e0d045a82077e3a6d8d14c2df43
Cr-Commit-Position: refs/heads/master@{#390242}

Powered by Google App Engine
This is Rietveld 408576698