Set needsPaintPhaseDescendantBlockBackgrounds if a table has collapsed borders

Set needsPaintPhaseDescendantBlockBackgrounds if a table has collapsed borders

No matter the actual borders are defined by which descendants and
whether the descedants have self-painting layer, a border-collapsing
table always paint collapsed borders in
PaintPhaseDescendantBlockBackgrounds.

Set needsPaintPhaseDescendantBlockBackgrounds if a table has visible
collapsed borders.

BUG=607022
TEST=PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds

Committed: https://crrev.com/ca106e2693d28e0d045a82077e3a6d8d14c2df43
Cr-Commit-Position: refs/heads/master@{#390242}

[Xianzhu, 2016-04-27 17:37:59]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-04-27 17:38:00]

Hope this is the last bug of empty paint phase optimization.

[chrishtr, 2016-04-27 19:57:22]

https://codereview.chromium.org/1925703003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp (right):

https://codereview.chromium.org/1925703003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp:520:
EXPECT_TRUE(layer.needsPaintPhaseDescendantBlockBackgrounds());
Also test that adding the property resuts in setting this bit.

[Xianzhu, 2016-04-27 22:08:38]

https://codereview.chromium.org/1925703003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp (right):

https://codereview.chromium.org/1925703003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp:520:
EXPECT_TRUE(layer.needsPaintPhaseDescendantBlockBackgrounds());
On 2016/04/27 19:57:22, chrishtr wrote:
> Also test that adding the property resuts in setting this bit.

Done.

[chrishtr, 2016-04-27 22:10:02]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-04-27 22:10:03]

lgtm

[commit-bot: I haz the power, 2016-04-27 22:10:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925703003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925703003/40001

[commit-bot: I haz the power, 2016-04-27 23:53:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:14:38]

Patchset 3 (id:??) landed as
https://crrev.com/ca106e2693d28e0d045a82077e3a6d8d14c2df43
Cr-Commit-Position: refs/heads/master@{#390242}

[commit-bot: I haz the power, 2016-04-30 17:53:01]

Description was changed from

==========
Set needsPaintPhaseDescendantBlockBackgrounds if a table has collapsed borders

No matter the actual borders are defined by which descendants and
whether the descedants have self-painting layer, a border-collapsing
table always paint collapsed borders in
PaintPhaseDescendantBlockBackgrounds.

Set needsPaintPhaseDescendantBlockBackgrounds if a table has visible
collapsed borders.

BUG=607022
TEST=PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds
==========

to

==========
Set needsPaintPhaseDescendantBlockBackgrounds if a table has collapsed borders

No matter the actual borders are defined by which descendants and
whether the descedants have self-painting layer, a border-collapsing
table always paint collapsed borders in
PaintPhaseDescendantBlockBackgrounds.

Set needsPaintPhaseDescendantBlockBackgrounds if a table has visible
collapsed borders.

BUG=607022
TEST=PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds

Committed: https://crrev.com/ca106e2693d28e0d045a82077e3a6d8d14c2df43
Cr-Commit-Position: refs/heads/master@{#390242}
==========