Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1925673002:
🐾 Reland of Enable instrumentation tests on Android Swarm Builder (Closed)
DescriptionReland of Enable instrumentation tests on Android Swarm Builder
Reason for revert:
- Now with proper test names and _run targets defined
(via a separate change)
TBR=dpranke
BUG=589318
Committed: https://crrev.com/2e039c2ac7a69ffb843b5e0b03fffa1edb1e8b57
Cr-Commit-Position: refs/heads/master@{#390223}
Patch Set 1 #Patch Set 2 : drop the _apk #
Total comments: 3
Patch Set 3 : added some hard_timeouts #
Messages
Total messages: 21 (9 generated)
Created Reland of 🐾 Enable instrumentation tests on Android Swarm Builder
Description was changed from ========== Reland of 🐾 Enable instrumentation tests on Android Swarm Builder (patchset #1 id:1 of https://codereview.chromium.org/1916303007/ ) Reason for revert: fixing Original issue's description: > Revert of Enable instrumentation tests on Android Swarm Builder (patchset #2 id:20001 of https://codereview.chromium.org/1918823006/ ) > > Reason for revert: > ninja: error: unknown target 'android_webview_test_apk_apk_run' > > Original issue's description: > > Enable instrumentation tests on Android Swarm Builder > > > > BUG=589318 > > > > Committed: https://crrev.com/42aecd2a6a2b51ac56fa594000007ba2eb784da1 > > Cr-Commit-Position: refs/heads/master@{#389974} > > TBR=jbudorick@chromium.org,dpranke@chromium.org,stip@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=589318 > > Committed: https://crrev.com/0e951e6770f4aad69478b177655c8b6bb6542d22 > Cr-Commit-Position: refs/heads/master@{#389982} TBR=jbudorick@chromium.org,dpranke@chromium.org,stip@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=589318 ========== to ========== Reland of Enable instrumentation tests on Android Swarm Builder Reason for revert: - Now with proper test names and _run targets defined (via a separate change) NOTRY=true BUG=589318 ==========
On 2016/04/27 13:32:10, agrieve wrote: > Created Reland of 🐾 Enable instrumentation tests on Android Swarm Builder Adding the _run target is here: https://codereview.chromium.org/1926673002/
Description was changed from ========== Reland of Enable instrumentation tests on Android Swarm Builder Reason for revert: - Now with proper test names and _run targets defined (via a separate change) NOTRY=true BUG=589318 ========== to ========== Reland of Enable instrumentation tests on Android Swarm Builder Reason for revert: - Now with proper test names and _run targets defined (via a separate change) BUG=589318 ==========
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925673002/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925673002/70001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1925673002/diff/70001/testing/buildbot/chromi... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/1925673002/diff/70001/testing/buildbot/chromi... testing/buildbot/chromium.android.json:24: "test": "android_webview_test" stip: Should we set hard_timeouts for these suites?
lgtm https://codereview.chromium.org/1925673002/diff/70001/testing/buildbot/chromi... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/1925673002/diff/70001/testing/buildbot/chromi... testing/buildbot/chromium.android.json:24: "test": "android_webview_test" On 2016/04/27 15:32:13, jbudorick wrote: > stip: Should we set hard_timeouts for these suites? I mean, yeah, but let's not worry about that until the bot is 100% up
https://codereview.chromium.org/1925673002/diff/70001/testing/buildbot/chromi... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/1925673002/diff/70001/testing/buildbot/chromi... testing/buildbot/chromium.android.json:24: "test": "android_webview_test" On 2016/04/27 20:02:57, stip wrote: > On 2016/04/27 15:32:13, jbudorick wrote: > > stip: Should we set hard_timeouts for these suites? > > I mean, yeah, but let's not worry about that until the bot is 100% up I just don't want these suites accidentally keeping capacity away from larng for too long.
added some hard_timeouts
Description was changed from ========== Reland of Enable instrumentation tests on Android Swarm Builder Reason for revert: - Now with proper test names and _run targets defined (via a separate change) BUG=589318 ========== to ========== Reland of Enable instrumentation tests on Android Swarm Builder Reason for revert: - Now with proper test names and _run targets defined (via a separate change) TBR=dpranke BUG=589318 ==========
The CQ bit was checked by agrieve@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stip@chromium.org Link to the patchset: https://codereview.chromium.org/1925673002/#ps90001 (title: "added some hard_timeouts")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925673002/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925673002/90001
Message was sent while issue was closed.
Description was changed from ========== Reland of Enable instrumentation tests on Android Swarm Builder Reason for revert: - Now with proper test names and _run targets defined (via a separate change) TBR=dpranke BUG=589318 ========== to ========== Reland of Enable instrumentation tests on Android Swarm Builder Reason for revert: - Now with proper test names and _run targets defined (via a separate change) TBR=dpranke BUG=589318 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:90001)
Message was sent while issue was closed.
rs lgtm.
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2e039c2ac7a69ffb843b5e0b03fffa1edb1e8b57 Cr-Commit-Position: refs/heads/master@{#390223}
Message was sent while issue was closed.
Description was changed from ========== Reland of Enable instrumentation tests on Android Swarm Builder Reason for revert: - Now with proper test names and _run targets defined (via a separate change) TBR=dpranke BUG=589318 ========== to ========== Reland of Enable instrumentation tests on Android Swarm Builder Reason for revert: - Now with proper test names and _run targets defined (via a separate change) TBR=dpranke BUG=589318 Committed: https://crrev.com/2e039c2ac7a69ffb843b5e0b03fffa1edb1e8b57 Cr-Commit-Position: refs/heads/master@{#390223} ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
