gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc - Issue 1925663002: command_buffer: Defer restoring of FBO bindings when changing virtual contexts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc

Issue 1925663002: command_buffer: Defer restoring of FBO bindings when changing virtual contexts Base URL: https://chromium.googlesource.com/chromium/src.git@lazy-bindframebuffer-03-copy-texture-chromium-instantiation

Patch Set: rework Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/gles2_cmd_decoder.cc ('K') | « gpu/command_buffer/service/gles2_cmd_decoder_mock.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h » ('j') | gpu/config/gpu_driver_bug_list_json.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc

index 2d034c3d5b6926a266221d71784e9f0c811969df..3df2518b331a3e06c619fa278fdcb659f242c8ee 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc

@@ -238,14 +238,7 @@ TEST_P(GLES2DecoderTest, IsFramebuffer) {

DoBindFramebuffer(

GL_FRAMEBUFFER, client_framebuffer_id_, kServiceFramebufferId);

EXPECT_TRUE(DoIsFramebuffer(client_framebuffer_id_));

- DoDeleteFramebuffer(client_framebuffer_id_,

- kServiceFramebufferId,

- true,

- GL_FRAMEBUFFER,

- 0,

- true,

- GL_FRAMEBUFFER,

- 0);

+ DoDeleteFramebuffer(client_framebuffer_id_, kServiceFramebufferId);

EXPECT_FALSE(DoIsFramebuffer(client_framebuffer_id_));

}