Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: runtime/vm/assembler_arm.h

Issue 19256021: Merges ARM load/store type enums into one enum. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm.h
===================================================================
--- runtime/vm/assembler_arm.h (revision 25061)
+++ runtime/vm/assembler_arm.h (working copy)
@@ -176,28 +176,19 @@
};
-enum LoadOperandType {
- kLoadSignedByte,
- kLoadUnsignedByte,
- kLoadSignedHalfword,
- kLoadUnsignedHalfword,
- kLoadWord,
- kLoadWordPair,
- kLoadSWord,
- kLoadDWord
+enum OperandSize {
+ kByte,
+ kUnsignedByte,
+ kHalfword,
+ kUnsignedHalfword,
+ kWord,
+ kUnsignedWord,
+ kWordPair,
+ kSWord,
+ kDWord,
};
-enum StoreOperandType {
- kStoreByte,
- kStoreHalfword,
- kStoreWord,
- kStoreWordPair,
- kStoreSWord,
- kStoreDWord
-};
-
-
// Load/store multiple addressing mode.
enum BlockAddressMode {
// bit encoding P U W
@@ -268,10 +259,10 @@
return (encoding_ == other.encoding_) && (kind_ == other.kind_);
}
- static bool CanHoldLoadOffset(LoadOperandType type,
+ static bool CanHoldLoadOffset(OperandSize type,
int32_t offset,
int32_t* offset_mask);
- static bool CanHoldStoreOffset(StoreOperandType type,
+ static bool CanHoldStoreOffset(OperandSize type,
int32_t offset,
int32_t* offset_mask);
@@ -479,15 +470,15 @@
void vadds(SRegister sd, SRegister sn, SRegister sm, Condition cond = AL);
void vaddd(DRegister dd, DRegister dn, DRegister dm, Condition cond = AL);
- void vaddqi(int sz, QRegister qd, QRegister qn, QRegister qm);
+ void vaddqi(OperandSize sz, QRegister qd, QRegister qn, QRegister qm);
void vaddqs(QRegister qd, QRegister qn, QRegister qm);
void vsubs(SRegister sd, SRegister sn, SRegister sm, Condition cond = AL);
void vsubd(DRegister dd, DRegister dn, DRegister dm, Condition cond = AL);
- void vsubqi(int sz, QRegister qd, QRegister qn, QRegister qm);
+ void vsubqi(OperandSize sz, QRegister qd, QRegister qn, QRegister qm);
void vsubqs(QRegister qd, QRegister qn, QRegister qm);
void vmuls(SRegister sd, SRegister sn, SRegister sm, Condition cond = AL);
void vmuld(DRegister dd, DRegister dn, DRegister dm, Condition cond = AL);
- void vmulqi(int sz, QRegister qd, QRegister qn, QRegister qm);
+ void vmulqi(OperandSize sz, QRegister qd, QRegister qn, QRegister qm);
void vmulqs(QRegister qd, QRegister qn, QRegister qm);
void vmlas(SRegister sd, SRegister sn, SRegister sm, Condition cond = AL);
void vmlad(DRegister dd, DRegister dn, DRegister dm, Condition cond = AL);
@@ -599,12 +590,12 @@
void CompareClassId(Register object, intptr_t class_id, Register scratch);
void LoadWordFromPoolOffset(Register rd, int32_t offset, Condition cond = AL);
- void LoadFromOffset(LoadOperandType type,
+ void LoadFromOffset(OperandSize type,
Register reg,
Register base,
int32_t offset,
Condition cond = AL);
- void StoreToOffset(StoreOperandType type,
+ void StoreToOffset(OperandSize type,
Register reg,
Register base,
int32_t offset,
@@ -813,7 +804,7 @@
DRegister dd,
SRegister sm);
- void EmitSIMDqqq(int32_t opcode, int sz,
+ void EmitSIMDqqq(int32_t opcode, OperandSize sz,
QRegister qd, QRegister qn, QRegister qm);
void EmitBranch(Condition cond, Label* label, bool link);
« no previous file with comments | « no previous file | runtime/vm/assembler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698