Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 19256020: Report initial_map field of JSFunction in heap snapshot. (Closed)

Created:
7 years, 5 months ago by alph
Modified:
7 years, 5 months ago
Reviewers:
yurys, Toon Verwaest, loislo
CC:
v8-dev
Visibility:
Public.

Description

Report initial_map field of JSFunction in heap snapshot. R=verwaest@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/heap-snapshot-generator.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alph
Ilya, Toon, could you please take a look.
7 years, 5 months ago (2013-07-16 18:08:18 UTC) #1
yurys
lgtm
7 years, 5 months ago (2013-07-16 18:28:43 UTC) #2
Toon Verwaest
lgtm
7 years, 5 months ago (2013-07-16 19:30:51 UTC) #3
alph
7 years, 5 months ago (2013-07-17 10:16:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r15711 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698