Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 19256015: Get rid of special casing for SVGAElement.target from the bindings generator (Closed)

Created:
7 years, 5 months ago by do-not-use
Modified:
7 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, pdr, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, f(malita), adamk+blink_chromium.org, Stephen Chennney, Nate Chapin, do-not-use, lgombos
Visibility:
Public.

Description

Get rid of special casing for SVGAElement.target from the bindings generator Get rid of special casing for SVGAElement.target from the bindings generator by using [ImplementedAs=svgTarget] for that attribute. R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M Source/bindings/scripts/deprecated_code_generator_v8.pm View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 5 months ago (2013-07-16 14:37:02 UTC) #1
haraken
LGTM
7 years, 5 months ago (2013-07-16 15:36:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19256015/1
7 years, 5 months ago (2013-07-16 15:43:03 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-16 17:25:47 UTC) #4
Message was sent while issue was closed.
Change committed as 154309

Powered by Google App Engine
This is Rietveld 408576698