Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 19256002: add table pregeneration script for pmetric (Closed)

Created:
7 years, 5 months ago by Zach Reizner
Modified:
7 years, 5 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add table pregeneration script for pmetric R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10106

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 1

Patch Set 8 : copyright #

Patch Set 9 : help #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2767 lines, -12 lines) Patch
M experimental/skpdiff/SkDiffContext.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M experimental/skpdiff/SkPMetric.cpp View 1 2 3 4 5 6 13 chunks +30 lines, -12 lines 0 comments Download
A experimental/skpdiff/SkPMetricUtil_generated.h View 1 2 3 4 5 6 7 8 1 chunk +2586 lines, -0 lines 0 comments Download
A experimental/skpdiff/generate_pmetric_tables.py View 1 2 3 4 5 6 7 8 1 chunk +149 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Zach Reizner
This commit also has the row pointers one for now because the tree is closed. ...
7 years, 5 months ago (2013-07-15 18:00:34 UTC) #1
Zach Reizner
Did the rebase and tons of other small tweaks.
7 years, 5 months ago (2013-07-16 13:54:41 UTC) #2
djsollen
https://codereview.chromium.org/19256002/diff/5002/experimental/skpdiff/SkPMetric.cpp File experimental/skpdiff/SkPMetric.cpp (right): https://codereview.chromium.org/19256002/diff/5002/experimental/skpdiff/SkPMetric.cpp#newcode283 experimental/skpdiff/SkPMetric.cpp:283: float * contrastSensitivityTable = SkNEW_ARRAY(float, maxLevels * 1000); float* ...
7 years, 5 months ago (2013-07-16 13:55:11 UTC) #3
Zach Reizner
7 years, 5 months ago (2013-07-16 15:00:36 UTC) #4
djsollen
lgtm if you add the info to the top of the generated file https://codereview.chromium.org/19256002/diff/17001/experimental/skpdiff/SkPMetricUtil_generated.h File ...
7 years, 5 months ago (2013-07-16 15:31:04 UTC) #5
Zach Reizner
7 years, 5 months ago (2013-07-16 15:47:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #9 manually as r10106 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698