Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1925593002: recipe engine: remove explicit cwd default in step recipe module (Closed)

Created:
4 years, 7 months ago by Paweł Hajdan Jr.
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://github.com/luci/recipes-py.git@master
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

recipe engine: remove explicit cwd default in step recipe module This was added in https://codereview.chromium.org/1115453002 to run on swarming. We no longer need this, because we're using kitchen with swarmbucket now, which is a different environment. This is a step towards removing infra-specific paths from the recipe engine. BUG=chromium:605919 Committed: https://github.com/luci/recipes-py/commit/d9039313202dfb6adaf890674abdd8ee6aec940d

Patch Set 1 #

Patch Set 2 : presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -193 lines) Patch
M recipe_modules/json/example.expected/basic.json View 6 chunks +0 lines, -6 lines 0 comments Download
M recipe_modules/path/example.expected/linux.json View 5 chunks +0 lines, -5 lines 0 comments Download
M recipe_modules/path/example.expected/linux_kitchen.json View 5 chunks +0 lines, -5 lines 0 comments Download
M recipe_modules/path/example.expected/linux_swarming.json View 5 chunks +0 lines, -5 lines 0 comments Download
M recipe_modules/path/example.expected/mac.json View 5 chunks +0 lines, -5 lines 0 comments Download
M recipe_modules/path/example.expected/mac_kitchen.json View 5 chunks +0 lines, -5 lines 0 comments Download
M recipe_modules/path/example.expected/mac_swarming.json View 5 chunks +0 lines, -5 lines 0 comments Download
M recipe_modules/path/example.expected/win.json View 5 chunks +0 lines, -5 lines 0 comments Download
M recipe_modules/path/example.expected/win_kitchen.json View 5 chunks +0 lines, -5 lines 0 comments Download
M recipe_modules/path/example.expected/win_swarming.json View 5 chunks +0 lines, -5 lines 0 comments Download
M recipe_modules/platform/example.expected/linux64.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/platform/example.expected/mac64.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/platform/example.expected/win32.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/properties/example.expected/basic.json View 2 chunks +0 lines, -2 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_generic.json View 2 chunks +0 lines, -2 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_git_scheduled.json View 2 chunks +0 lines, -2 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_scheduled.json View 2 chunks +0 lines, -2 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_tryserver.json View 2 chunks +0 lines, -2 lines 0 comments Download
M recipe_modules/properties/example.expected/buildbot_tryserver_gerrit.json View 2 chunks +0 lines, -2 lines 0 comments Download
M recipe_modules/properties/example.expected/dicts.json View 2 chunks +0 lines, -2 lines 0 comments Download
M recipe_modules/properties/example.expected/lists.json View 2 chunks +0 lines, -2 lines 0 comments Download
M recipe_modules/python/example.expected/basic.json View 2 chunks +0 lines, -2 lines 0 comments Download
M recipe_modules/raw_io/example.expected/basic.json View 8 chunks +0 lines, -8 lines 0 comments Download
M recipe_modules/shutil/example.expected/basic.json View 21 chunks +0 lines, -21 lines 0 comments Download
M recipe_modules/step/__init__.py View 1 1 chunk +4 lines, -1 line 0 comments Download
M recipe_modules/step/api.py View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/step/example.expected/basic.json View 13 chunks +0 lines, -13 lines 0 comments Download
M recipe_modules/step/example.expected/defer_results.json View 11 chunks +0 lines, -11 lines 0 comments Download
M recipe_modules/step/example.expected/exceptional.json View 8 chunks +0 lines, -8 lines 0 comments Download
M recipe_modules/step/example.expected/infra_failure.json View 13 chunks +0 lines, -13 lines 0 comments Download
M recipe_modules/step/example.expected/invalid_access.json View 14 chunks +0 lines, -14 lines 0 comments Download
M recipe_modules/step/example.expected/warning.json View 9 chunks +0 lines, -9 lines 0 comments Download
M recipe_modules/tempfile/example.expected/basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/time/example.expected/defaults.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/time/example.expected/seed_and_step.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/uuid/example.expected/basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/engine_tests/depend_on/bottom.expected/basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/engine_tests/depend_on/no_return.expected/basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/engine_tests/functools_partial.expected/basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/engine_tests/multi_test_data.expected/basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/engine_tests/nonexistent_command.expected/basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/engine_tests/subannotations.expected/basic.json View 2 chunks +0 lines, -2 lines 0 comments Download
M recipes/engine_tests/trigger.expected/basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/example/defer.expected/basic.json View 2 chunks +0 lines, -2 lines 0 comments Download
M recipes/example/defer.expected/one_fail.json View 2 chunks +0 lines, -2 lines 0 comments Download
M recipes/example/nested.expected/basic.json View 5 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Paweł Hajdan Jr.
4 years, 7 months ago (2016-04-27 09:15:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925593002/1
4 years, 7 months ago (2016-04-27 09:16:04 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Recipes-py%20Presubmit/builds/185)
4 years, 7 months ago (2016-04-27 09:20:12 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925593002/20001
4 years, 7 months ago (2016-04-27 09:20:31 UTC) #8
Michael Achenbach
lgtm
4 years, 7 months ago (2016-04-27 09:20:32 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 09:22:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925593002/20001
4 years, 7 months ago (2016-04-27 09:23:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://github.com/luci/recipes-py/commit/d9039313202dfb6adaf890674abdd8ee6aec940d
4 years, 7 months ago (2016-04-27 09:24:46 UTC) #15
Sergiy Byelozyorov
4 years, 7 months ago (2016-04-27 12:33:53 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698