Revert of Enable flattening of SkRecordedDrawable

Revert of Enable flattening of SkRecordedDrawable (patchset #8 id:140001 of https://codereview.chromium.org/1913843002/ )

Reason for revert:
nanobench failing (skps ?)

Original issue's description:
> Enable flattening of SkRecordedDrawable
> 
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913843002
> 
> Committed: https://skia.googlesource.com/skia/+/d636950e8ecba89c0021ce4e76037c67aa6ee2cd

TBR=mtklein@google.com,djsollen@google.com,msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

[reed1, 2016-04-27 16:29:43]

Created Revert of Enable flattening of SkRecordedDrawable

[commit-bot: I haz the power, 2016-04-27 16:29:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1925583005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1925583005/1

[commit-bot: I haz the power, 2016-04-27 16:29:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 16:30:00]

Failed to apply patch for src/core/SkRecordedDrawable.cpp:
While running git rm src/core/SkRecordedDrawable.cpp;
  fatal: pathspec 'src/core/SkRecordedDrawable.cpp' did not match any files

Patch:  D    src/core/SkRecordedDrawable.cpp
Index: src/core/SkRecordedDrawable.cpp
diff --git a/src/core/SkRecordedDrawable.cpp b/src/core/SkRecordedDrawable.cpp
deleted file mode 100644
index
9b5874f9272865047d0b58a770e4f2b0ddeca70b..0000000000000000000000000000000000000000
--- a/src/core/SkRecordedDrawable.cpp
+++ /dev/null
@@ -1,102 +0,0 @@
-/*
- * Copyright 2016 Google Inc.
- *
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file.
- */
-
-#include "SkLayerInfo.h"
-#include "SkMatrix.h"
-#include "SkPictureData.h"
-#include "SkPicturePlayback.h"
-#include "SkPictureRecord.h"
-#include "SkPictureRecorder.h"
-#include "SkPictureUtils.h"
-#include "SkRecordedDrawable.h"
-#include "SkRecordDraw.h"
-
-void SkRecordedDrawable::onDraw(SkCanvas* canvas) {
-    SkDrawable* const* drawables = nullptr;
-    int drawableCount = 0;
-    if (fDrawableList) {
-        drawables = fDrawableList->begin();
-        drawableCount = fDrawableList->count();
-    }
-    SkRecordDraw(*fRecord, canvas, nullptr, drawables, drawableCount, fBBH,
nullptr/*callback*/);
-}
-
-SkPicture* SkRecordedDrawable::onNewPictureSnapshot() {
-    SkBigPicture::SnapshotArray* pictList = nullptr;
-    if (fDrawableList) {
-        // TODO: should we plumb-down the BBHFactory and recordFlags from our
host
-        //       PictureRecorder?
-        pictList = fDrawableList->newDrawableSnapshot();
-    }
-
-    SkAutoTUnref<SkLayerInfo> saveLayerData;
-    if (fBBH && fDoSaveLayerInfo) {
-        // TODO: can we avoid work by not allocating / filling these bounds?
-        SkAutoTMalloc<SkRect> scratchBounds(fRecord->count());
-        saveLayerData.reset(new SkLayerInfo);
-
-        SkRecordComputeLayers(fBounds, *fRecord, scratchBounds, pictList,
saveLayerData);
-    }
-
-    size_t subPictureBytes = 0;
-    for (int i = 0; pictList && i < pictList->count(); i++) {
-        subPictureBytes +=
SkPictureUtils::ApproximateBytesUsed(pictList->begin()[i]);
-    }
-    // SkBigPicture will take ownership of a ref on both fRecord and fBBH.
-    // We're not willing to give up our ownership, so we must ref them for
SkPicture.
-    return new SkBigPicture(fBounds, SkRef(fRecord.get()), pictList,
SkSafeRef(fBBH.get()),
-                            saveLayerData.release(), subPictureBytes);
-}
-
-void SkRecordedDrawable::flatten(SkWriteBuffer& buffer) const {
-    // Write the bounds.
-    buffer.writeRect(fBounds);
-
-    // Create an SkPictureRecord to record the draw commands.
-    SkPictInfo info;
-    SkPictureRecord pictureRecord(SkISize::Make(fBounds.width(),
fBounds.height()), 0);
-
-    // If the query contains the whole picture, don't bother with the bounding
box hierarchy.
-    SkRect clipBounds;
-    pictureRecord.getClipBounds(&clipBounds);
-    SkBBoxHierarchy* bbh;
-    if (clipBounds.contains(fBounds)) {
-        bbh = nullptr;
-    } else {
-        bbh = fBBH.get();
-    }
-
-    // Record the draw commands.
-    pictureRecord.beginRecording();
-    SkRecordDraw(*fRecord, &pictureRecord, nullptr, fDrawableList->begin(),
fDrawableList->count(),
-                bbh, nullptr);
-    pictureRecord.endRecording();
-
-    // Flatten the recorded commands and drawables.
-    SkPictureData pictureData(pictureRecord, info, false);
-    pictureData.flatten(buffer);
-}
-
-sk_sp<SkFlattenable> SkRecordedDrawable::CreateProc(SkReadBuffer& buffer) {
-    // Read the bounds.
-    SkRect bounds;
-    buffer.readRect(&bounds);
-
-    // Unflatten into a SkPictureData.
-    SkPictInfo info;
-    info.fCullRect = bounds;
-    SkAutoTDelete<SkPictureData>
pictureData(SkPictureData::CreateFromBuffer(buffer, info));
-    if (!pictureData) {
-        return nullptr;
-    }
-
-    // Create a drawable.
-    SkPicturePlayback playback(pictureData);
-    SkPictureRecorder recorder;
-    playback.draw(recorder.beginRecording(bounds), nullptr, &buffer);
-    return recorder.finishRecordingAsDrawable();
-}

[msarett, 2016-05-06 13:20:26]

Description was changed from

==========
Revert of Enable flattening of SkRecordedDrawable (patchset #8 id:140001 of
https://codereview.chromium.org/1913843002/ )

Reason for revert:
nanobench failing (skps ?)

Original issue's description:
> Enable flattening of SkRecordedDrawable
> 
> BUG=skia:
> GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
> 
> Committed:
https://skia.googlesource.com/skia/+/d636950e8ecba89c0021ce4e76037c67aa6ee2cd

TBR=mtklein@google.com,djsollen@google.com,msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
==========

to

==========
Revert of Enable flattening of SkRecordedDrawable (patchset #8 id:140001 of
https://codereview.chromium.org/1913843002/ )

Reason for revert:
nanobench failing (skps ?)

Original issue's description:
> Enable flattening of SkRecordedDrawable
> 
> BUG=skia:
> GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
> 
> Committed:
https://skia.googlesource.com/skia/+/d636950e8ecba89c0021ce4e76037c67aa6ee2cd

TBR=mtklein@google.com,djsollen@google.com,msarett@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
==========